Skip to content

[hotfix][docs] Add module-level AGENTS.md guides and fix stale root claims - #2

Open
Vamsi-klu wants to merge 2 commits into
masterfrom
cursor/agents-md-guides-4436
Open

[hotfix][docs] Add module-level AGENTS.md guides and fix stale root claims#2
Vamsi-klu wants to merge 2 commits into
masterfrom
cursor/agents-md-guides-4436

Conversation

@Vamsi-klu

@Vamsi-klu Vamsi-klu commented Aug 21, 2026

Copy link
Copy Markdown
Owner

What is the purpose of the change

Continue FLINK-39477 item 3: module-level AGENTS.md guides for the modules agents actually edit, plus two stale claims in the root AGENTS.md.

Related PRs:

This branch is rebased onto current apache/flink master. The Cursor GitHub App cannot open PRs on apache/flink. Open the real review PR as Vamsi-klu:

https://github.com/apache/flink/compare/master...Vamsi-klu:flink:cursor/agents-md-guides-4436?expand=1

This fork PR is only a holding copy of that branch.

Codex review 4996867308 is addressed in 6be96e7000f: application-mode main() can run on the JobManager, and REST docs regenerate via -Dgenerate-rest-docs.

Brief change log

  • Add AGENTS.md for flink-core, flink-runtime, flink-streaming-java, flink-clients, flink-table-common, flink-table-api-java, flink-connector-base, and flink-statebackend-rocksdb
  • Document that the DataStream API, operator/task base classes, and StreamGraph live in flink-runtime (org.apache.flink.streaming.*) after FLINK-36063
  • Fix the root Checkstyle note: every module inherits maven-checkstyle-plugin in validate with failOnViolation=true. flink-core and flink-runtime only override their suppressions file. flink-optimizer is not a module here
  • Add a "Module-specific agent guides" index to the root AGENTS.md
  • Qualify JobManager / application-mode wording so agents do not treat main() as client-only
  • Point REST handler changes at ./mvnw package -Dgenerate-rest-docs and the real shortcode/OpenAPI output paths

Verifying this change

Documentation only. Checked against current master:

  • DataStream.java is in flink-runtime, not flink-streaming-java
  • flink-core and flink-runtime poms override suppressionsLocation only
  • Dispatcher.maybeSubmitApplicationInApplicationMode() and PackagedProgramApplication run the user entry point on the JobManager in application mode
  • flink-docs generate-rest-docs profile writes docs/layouts/shortcodes/generated/rest_v1_dispatcher.html and docs/static/generated/rest_v1_dispatcher.yml
  • License headers match the existing planner/runtime AGENTS.md files

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (Claude Opus 4.8); Cursor Grok 4.6 (rebase onto current master and Codex review fixes)

Open in Web Open in Cursor 

…laims

Add AGENTS.md agent guides for flink-core, flink-runtime, flink-streaming-java,
flink-clients, flink-table-common, flink-table-api-java, flink-connector-base,
and flink-statebackend-rocksdb, following the existing flink-table-planner /
flink-table-runtime pattern (role, build commands, key directory structure, key
abstractions, common change patterns, testing patterns). Every class, path, and
extends/implements claim was verified against the source tree.

Also correct two stale claims in the root AGENTS.md:
- flink-streaming-java / flink-runtime: the DataStream API, the operator/task
  base classes, StreamGraph, and the windowing base interfaces were migrated
  into flink-runtime (org.apache.flink.streaming.*) by FLINK-36063; the root
  module list now reflects that.
- Checkstyle: every module is enforced (maven-checkstyle-plugin, validate phase,
  failOnViolation=true); flink-core and flink-runtime only override their
  suppressions file. The previous text wrongly listed them (plus a non-existent
  flink-optimizer module) as not checkstyle-enforced. Verified by running
  `mvnw -pl flink-core checkstyle:check` (0 violations).

Add a "Module-specific agent guides" cross-link list to the root AGENTS.md.

Generated-by: Claude Code (Claude Opus 4.8)
@Vamsi-klu
Vamsi-klu marked this pull request as ready for review August 21, 2026 19:43
@cursor

cursor Bot commented Aug 21, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28cb7c6cb7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flink-clients/AGENTS.md Outdated
Comment thread flink-runtime/AGENTS.md Outdated
…ENTS.md

Address the Codex review on #2: application-mode main()
can run on the JobManager, and REST docs are regenerated via
-Dgenerate-rest-docs into the shortcode/OpenAPI paths.

Generated-by: Cursor Grok 4.6

Co-authored-by: deepinsight coder <Vamsi-klu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants