[hotfix][docs] Add module-level AGENTS.md guides and fix stale root claims - #2
Open
Vamsi-klu wants to merge 2 commits into
Open
[hotfix][docs] Add module-level AGENTS.md guides and fix stale root claims#2Vamsi-klu wants to merge 2 commits into
Vamsi-klu wants to merge 2 commits into
Conversation
…laims Add AGENTS.md agent guides for flink-core, flink-runtime, flink-streaming-java, flink-clients, flink-table-common, flink-table-api-java, flink-connector-base, and flink-statebackend-rocksdb, following the existing flink-table-planner / flink-table-runtime pattern (role, build commands, key directory structure, key abstractions, common change patterns, testing patterns). Every class, path, and extends/implements claim was verified against the source tree. Also correct two stale claims in the root AGENTS.md: - flink-streaming-java / flink-runtime: the DataStream API, the operator/task base classes, StreamGraph, and the windowing base interfaces were migrated into flink-runtime (org.apache.flink.streaming.*) by FLINK-36063; the root module list now reflects that. - Checkstyle: every module is enforced (maven-checkstyle-plugin, validate phase, failOnViolation=true); flink-core and flink-runtime only override their suppressions file. The previous text wrongly listed them (plus a non-existent flink-optimizer module) as not checkstyle-enforced. Verified by running `mvnw -pl flink-core checkstyle:check` (0 violations). Add a "Module-specific agent guides" cross-link list to the root AGENTS.md. Generated-by: Claude Code (Claude Opus 4.8)
Vamsi-klu
marked this pull request as ready for review
August 21, 2026 19:43
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28cb7c6cb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ENTS.md Address the Codex review on #2: application-mode main() can run on the JobManager, and REST docs are regenerated via -Dgenerate-rest-docs into the shortcode/OpenAPI paths. Generated-by: Cursor Grok 4.6 Co-authored-by: deepinsight coder <Vamsi-klu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Continue FLINK-39477 item 3: module-level
AGENTS.mdguides for the modules agents actually edit, plus two stale claims in the rootAGENTS.md.Related PRs:
AGENTS.mdand AI disclosureThis branch is rebased onto current
apache/flinkmaster. The Cursor GitHub App cannot open PRs onapache/flink. Open the real review PR as Vamsi-klu:https://github.com/apache/flink/compare/master...Vamsi-klu:flink:cursor/agents-md-guides-4436?expand=1
This fork PR is only a holding copy of that branch.
Codex review 4996867308 is addressed in
6be96e7000f: application-modemain()can run on the JobManager, and REST docs regenerate via-Dgenerate-rest-docs.Brief change log
AGENTS.mdforflink-core,flink-runtime,flink-streaming-java,flink-clients,flink-table-common,flink-table-api-java,flink-connector-base, andflink-statebackend-rocksdbStreamGraphlive inflink-runtime(org.apache.flink.streaming.*) after FLINK-36063maven-checkstyle-plugininvalidatewithfailOnViolation=true.flink-coreandflink-runtimeonly override their suppressions file.flink-optimizeris not a module hereAGENTS.mdmain()as client-only./mvnw package -Dgenerate-rest-docsand the real shortcode/OpenAPI output pathsVerifying this change
Documentation only. Checked against current
master:DataStream.javais inflink-runtime, notflink-streaming-javaflink-coreandflink-runtimepoms overridesuppressionsLocationonlyDispatcher.maybeSubmitApplicationInApplicationMode()andPackagedProgramApplicationrun the user entry point on the JobManager in application modeflink-docsgenerate-rest-docsprofile writesdocs/layouts/shortcodes/generated/rest_v1_dispatcher.htmlanddocs/static/generated/rest_v1_dispatcher.ymlAGENTS.mdfilesDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.8); Cursor Grok 4.6 (rebase onto current master and Codex review fixes)