Repository navigation
Conversation
…e archive handles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GetMemoryMappedStreamIfPossiblereturns a lightweight stream over that mapping.ReadEntryreads withRandomAccessfrom the cached handles.Benchmark
pak01_dir.vpkpak01_dir.vpkReadEntry, entries up to 4 KiBVerifyChunkHashes, CS2 archives 0-5Fixes
ReadEntrycalls could return wrong data.EndOfStreamException.Readagain kept the previous package's signature and checksums, andIsDirVPKnever reset inSetFileName.AddFileon a optimized package appended unsorted, soFindEntrymissed the file.Read(Stream)andWrite(Stream)broke when the package did not start at position 0, and writing into a longer stream hashed the leftover bytes.InvalidDataException.Behaviour changes
GetMemoryMappedStreamIfPossiblereturns an internal stream type instead ofMemoryMappedViewStream. Returned streams must not be disposed while another thread reads them.FileShare.ReadWrite.ReadEntry,GetMemoryMappedStreamIfPossibleand theVerify*methods throwObjectDisposedExceptionafterDispose.I ran this PR over hundreds of different game paks and they read identical to before.