fix: Handle run-test-payment failures safely - #153
Open
ValeraFinebits wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a safety boundary around cheat-mode test payments to prevent plugin or host shutdowns.
Changes:
- Returns
400for null request bodies. - Logs unexpected failures while preserving cancellation behavior.
- Updates null-body test coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
UIPayJoinController.cs |
Adds validation and exception handling. |
UIPayJoinControllerTests.cs |
Verifies null bodies return 400. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ValeraFinebits
marked this pull request as ready for review
August 19, 2026 19:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /plugins/payjoin/run-test-paymentthrew on a malformed body and let anyfailure from the payjoin flow escape the action. BTCPay reacts to an exception
escaping plugin code by disabling the plugin and stopping the host, so a bad
request or a transient RPC error took the whole dev server down. The endpoint is
[CheatModeRoute], so this only hit cheat-mode servers, which is where themanual test plan runs.
400instead of throwingArgumentNullException.RunTestPaymentCoreAsync, wrapped in a catch that logs andreports. A genuine cancellation is still re-thrown.