Fix Euroscope v3.2.11 flickering aircraft issue. - #15
Open
CraigHowarth62 wants to merge 1 commit into
Open
Conversation
Cause *char passed to the Patenoids map as callsign In this ES version the memory location hops around for the callsign string so hundreds of duplicate map entries are created and when retireved during refresh there is no map entry that matches the supplied changed *char callsign Solution map the string and not the *char pointer
|
Thanks for doing this. Unfortunately I don't have time to review this at the moment (we don't support the latest versions so this is very low on my priority). |
Author
|
No worries - I did it for the mentor S1's who are using this version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Euroscope version v3.2.11 has missing / constantly appearing / disappearing a/c on the SMR display
During refresh the retrieved patetoid for AircraftCallsign is empty.
Cause: *char pointer passed to the Patetoids map instead of string callsign.
In this ES version, the memory location hops around for the callsign * char pointer so hundreds of duplicate map entries are created during position updates and when retireved during refresh for drawing there is no map entry that matches the supplied changed *char callsign.
Solution map the string and not the *char pointer by converting the map key type to string.