Skip to content

Fix TopSky-Incorrect-Push workflow - #1570

Open
Liaely wants to merge 1 commit into
mainfrom
fix-ts-file-check
Open

Fix TopSky-Incorrect-Push workflow#1570
Liaely wants to merge 1 commit into
mainfrom
fix-ts-file-check

Conversation

@Liaely

@Liaely Liaely commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Partially fixes #1478

Summary of changes

Amends the TopSky-Incorrect-Push workflow to correctly validate and test. It now will be able to fail.

Screenshots

Note: There has since been minor changes to wording, but not to the logic elements since the screenshot was made.

Screenshots taken in a private testing repository.

Failure example:

image

Success example:

image

Additional information

AI (GitHub Copilot) was used to assist in making these changes (primarily for my own experimentation regarding it 🤔 ); I have tested them and understand them as if I had done them myself.

Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
@Liaely Liaely added bug For bugs in existing functionality no-changelog No changelog entry is required labels Aug 30, 2026
@Liaely

Liaely commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator Author

#1478 (comment)

@Liaely can we make it easier to work out what we should/n't edit in the UK/Data/Plugin/TopSky_* folders too? @mid-archie and I originally made changes in one of the TopSkyCPDLC.txt files before it was pointed out that this was now a shared file. But neither GitHub nor the file itself made reference to this. Can we maybe put a big comment at the top of all the auto-generated files that says "DON'T EDIT THIS"?

@hazzas-99 I think this should fix it! I've cherry-picked the commit whilst I work on the compiler itself proper so that it can be put into practice quicker.
(The whole point of the workflow is to scream at you if you edit the wrong shared files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For bugs in existing functionality no-changelog No changelog entry is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amend TopSky compiler

1 participant