HasInstance boolean for unsubscribing from events in OnDisable/OnDestroy#27
Open
my-dimons wants to merge 3 commits into
Open
HasInstance boolean for unsubscribing from events in OnDisable/OnDestroy#27my-dimons wants to merge 3 commits into
my-dimons wants to merge 3 commits into
Conversation
The HasInstance boolean checks if an instance of the singleton exists without spawning a new singleton. Fixes an issue with events when trying to unsubscribe in OnDestroy/OnDisable in UnityCommunity#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue brought up in #17
Changes
HasInstanceboolean in theMonoSingleton<T>andSingleton<T>scripts.README.mdwith a "Common Issues" section which lists why this error happens, and how to fix itI ran into this error when making my own game using this package and trying to unsubscribe from events. I tried the fix described in the response and it worked, but I saw there was no fix in the project for it. I would have to add it to every script I made if I didn't fix it, so here we are.