fix: Arm64 test failures#3619
Merged
NoelStephensUnity merged 2 commits intodevelop-2.0.0from Aug 22, 2025
Merged
Conversation
- Increased the timeout duration because the raspberry pi that tests were run on is quite slow and sometimes doesn't make the timeout - Removed booleans from structures that are created via random bytes because Arm64 doesn't handle booleans the same way as x86, and bool(1) doesn't compare as equal to bool(2) like it does on x86 - Removed booleans from the network variable HashSet test because it created an infinite loop, because bool(1) and bool(2) DO apparently HASH to the same key on arm64, where they create different keys on x86. (This was never a valid test to begin with, because creating a hash set with 32 boolean key values is, strictly speaking, not possible, and only worked by accident on x86)
ShadauxCat
requested review from
a team,
EmandM,
NoelStephensUnity and
jabbacakes
as code owners
NoelStephensUnity
approved these changes
Aug 22, 2025
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Thank you Kitty for fixing this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes some test failures when running against arm64:
Documentation
Testing & QA
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?If any boxes above are checked, please add QA as a PR reviewer.
Backport
Not needed.