[RPW] Switch to default and current render pipeline

We complete switching to the newest API in GraphicsSettings.

GraphicsSettings.renderPipelineAsset API will be deprecated and it's replaced by defaultRenderPipeline. 
We should use GraphicsSettings.defaultRenderPipeline or GraphicsSettings.currentRenderPipeline.

Incorrect API was used in some places. It supposed to rely on the current pipeline instead of default as we may not have a default but we could still have RP in the Quality Settings.

1. Scene Render mode window could have incorrect height
2. Avatar previews could be handled incorrectly
3. Light component have an issue in a multiple RP projects
4. ScreenSpaceAmbientOcclusion may not work when URP is deferred in a multiple RP projects
5. Enlighten Manager may not work if you don't set RP asset in the GraphicsSettings


https://jira.unity3d.com/browse/UUM-66743

Author: kirill-titov-u

Packages/com.unity.render-pipelines.core/Editor/Utilities/SceneRenderPipelineEditor.cs

@@ -11,12 +11,12 @@ public override VisualElement CreateInspectorGUI()
         {
             var root = new VisualElement();
             root.Add(new HelpBox("This script is <b>Editor Only</b>.\nIt <b>modifies the project configuration</b> when this scene is opened.\nUse it with caution.", HelpBoxMessageType.Warning));
-        
+
             var rpAssetProperty = serializedObject.FindProperty("renderPipelineAsset");
             var rpAssetField = new PropertyField(rpAssetProperty);
-            rpAssetField.RegisterValueChangeCallback(evt => GraphicsSettings.renderPipelineAsset = rpAssetProperty.objectReferenceValue as RenderPipelineAsset);
+            rpAssetField.RegisterValueChangeCallback(evt => GraphicsSettings.defaultRenderPipeline = rpAssetProperty.objectReferenceValue as RenderPipelineAsset);
             root.Add(rpAssetField);
             return root;
         }
     }
-}
+}

Packages/com.unity.render-pipelines.core/Runtime/Utilities/SceneRenderPipeline.cs

@@ -28,7 +28,7 @@ void Awake()
         {
             if (firstTimeCreated)
             {
-                renderPipelineAsset = GraphicsSettings.renderPipelineAsset;
+                renderPipelineAsset = GraphicsSettings.defaultRenderPipeline;
                 firstTimeCreated = false;
             }
 
@@ -38,7 +38,7 @@ void Awake()
 
         void OnEnable()
         {
-            GraphicsSettings.renderPipelineAsset = renderPipelineAsset;
+            GraphicsSettings.defaultRenderPipeline = renderPipelineAsset;
         }
 
 
@@ -78,7 +78,7 @@ static public void SendAnalytic(SceneRenderPipeline sender)
             Data m_Data;
         }
 
-      
+
 #endif
     }
 }

Packages/com.unity.render-pipelines.core/Tests/Editor/Volumes/RenderPipelineTests.cs

@@ -14,35 +14,35 @@ class RenderPipelineTests
         [SetUp]
         public virtual void Setup()
         {
-            m_PreviousRenderPipelineAssetInGraphicsSettings = GraphicsSettings.renderPipelineAsset;
+            m_PreviousRenderPipelineAssetInGraphicsSettings = GraphicsSettings.defaultRenderPipeline;
             m_PreviousRenderPipelineAssetInQualitySettings = QualitySettings.renderPipeline;
         }
 
         [TearDown]
         public virtual void TearDown()
         {
-            GraphicsSettings.renderPipelineAsset = m_PreviousRenderPipelineAssetInGraphicsSettings;
+            GraphicsSettings.defaultRenderPipeline = m_PreviousRenderPipelineAssetInGraphicsSettings;
             QualitySettings.renderPipeline = m_PreviousRenderPipelineAssetInQualitySettings;
             UnityEngine.Object.DestroyImmediate(m_CreatedRenderPipelineAsset);
         }
 
         protected void SetupRenderPipeline<T>() where T : RenderPipelineAsset
         {
             m_CreatedRenderPipelineAsset = ScriptableObject.CreateInstance<T>();
-            GraphicsSettings.renderPipelineAsset = m_CreatedRenderPipelineAsset;
+            GraphicsSettings.defaultRenderPipeline = m_CreatedRenderPipelineAsset;
             QualitySettings.renderPipeline = m_CreatedRenderPipelineAsset;
         }
 
         protected void SetupRenderPipeline(Type renderPipelineType)
         {
             m_CreatedRenderPipelineAsset = (RenderPipelineAsset) ScriptableObject.CreateInstance(renderPipelineType);
-            GraphicsSettings.renderPipelineAsset = m_CreatedRenderPipelineAsset;
+            GraphicsSettings.defaultRenderPipeline = m_CreatedRenderPipelineAsset;
             QualitySettings.renderPipeline = m_CreatedRenderPipelineAsset;
         }
 
         protected void RemoveRenderPipeline()
         {
-            GraphicsSettings.renderPipelineAsset = null;
+            GraphicsSettings.defaultRenderPipeline = null;
             QualitySettings.renderPipeline = null;
         }
 

Packages/com.unity.render-pipelines.high-definition/Editor/RenderPipeline/Settings/QualitySettingsPanel.cs

@@ -162,13 +162,13 @@ void OnHDRPAssetSelected(ReorderableList list)
             /// </summary>
             static void PopulateHDRPAssetsFromQualitySettings(List<HDRPAssetLocations> target)
             {
-                if (GraphicsSettings.renderPipelineAsset is HDRenderPipelineAsset hdrp)
+                if (GraphicsSettings.defaultRenderPipeline is HDRenderPipelineAsset hdrp)
                     target.Add(new HDRPAssetLocations(true, hdrp));
 
                 var qualityLevelCount = QualitySettings.names.Length;
                 for (var i = 0; i < qualityLevelCount; ++i)
                 {
-                    if (!(QualitySettings.GetRenderPipelineAssetAt(i) is HDRenderPipelineAsset hdrp2))
+                    if (QualitySettings.GetRenderPipelineAssetAt(i) is not HDRenderPipelineAsset hdrp2)
                         continue;
 
                     var index = target.FindIndex(a => a.asset == hdrp2);

Packages/com.unity.render-pipelines.high-definition/Editor/Wizard/HDWizard.Configuration.cs

@@ -450,7 +450,7 @@ void FixShadowmask(bool fromAsyncUnused)
 
         // To be removed as soon as GraphicsSettings.renderPipelineAsset is removed
         bool IsHdrpAssetGraphicsUsedCorrect()
-            => GraphicsSettings.renderPipelineAsset is HDRenderPipelineAsset;
+            => GraphicsSettings.defaultRenderPipeline is HDRenderPipelineAsset;
 
         void FixHdrpAssetGraphicsUsed(bool fromAsync)
         {
@@ -459,7 +459,7 @@ void FixHdrpAssetGraphicsUsed(bool fromAsync)
             CreateOrLoad<HDRenderPipelineAsset>(fromAsync
                 ? () => m_Fixer.Stop()
                 : (Action)null,
-                asset => GraphicsSettings.renderPipelineAsset = asset);
+                asset => GraphicsSettings.defaultRenderPipeline = asset);
         }
 
         bool IsHdrpAssetQualityUsedCorrect()
@@ -594,15 +594,15 @@ IEnumerable<IMigratableAsset> migratableAssets
                     if (QualitySettings.GetRenderPipelineAssetAt(i) is HDRenderPipelineAsset qualityAsset)
                         collection.Add(qualityAsset);
                 }
-                if (GraphicsSettings.renderPipelineAsset is HDRenderPipelineAsset graphicsAsset)
+                if (GraphicsSettings.defaultRenderPipeline is HDRenderPipelineAsset graphicsAsset)
                     collection.Add(graphicsAsset);
 
                 return collection;
             }
         }
 
         bool IsMigratableAssetsCorrect()
-            => !migratableAssets.Any(asset => !asset.IsAtLastVersion());
+            => migratableAssets.All(asset => asset.IsAtLastVersion());
 
         void FixMigratableAssets(bool fromAsyncUnused)
         {

Packages/com.unity.render-pipelines.high-definition/Editor/Wizard/HDWizard.UIElement.cs

@@ -127,7 +127,7 @@ void CreateOrLoad<T>(Action onCancel, Action<T> onObjectChanged)
             {
                 title = Style.hdrpAssetDisplayDialogTitle;
                 content = Style.hdrpAssetDisplayDialogContent;
-                target = GraphicsSettings.renderPipelineAsset as HDRenderPipelineAsset;
+                target = GraphicsSettings.defaultRenderPipeline as HDRenderPipelineAsset;
             }
             else
                 throw new ArgumentException("Unknown type used");
@@ -144,7 +144,7 @@ void CreateOrLoad<T>(Action onCancel, Action<T> onObjectChanged)
                     AssetDatabase.Refresh();
 
                     if (typeof(T) == typeof(HDRenderPipelineAsset))
-                        GraphicsSettings.renderPipelineAsset = asset as HDRenderPipelineAsset;
+                        GraphicsSettings.defaultRenderPipeline = asset as HDRenderPipelineAsset;
                     break;
                 case 1: //cancel
                     onCancel?.Invoke();

Packages/com.unity.render-pipelines.high-definition/Runtime/RenderPipeline/Utility/HDUtils.cs

@@ -595,14 +595,14 @@ internal static string GetVFXPath()
         // It returns the previously set RenderPipelineAsset, assetWasFromQuality is true if the current asset was set through the quality settings
         internal static RenderPipelineAsset SwitchToBuiltinRenderPipeline(out bool assetWasFromQuality)
         {
-            var graphicSettingAsset = GraphicsSettings.renderPipelineAsset;
+            var graphicSettingAsset = GraphicsSettings.defaultRenderPipeline;
             assetWasFromQuality = false;
             if (graphicSettingAsset != null)
             {
                 // Check if the currently used pipeline is the one from graphics settings
                 if (GraphicsSettings.currentRenderPipeline == graphicSettingAsset)
                 {
-                    GraphicsSettings.renderPipelineAsset = null;
+                    GraphicsSettings.defaultRenderPipeline = null;
                     return graphicSettingAsset;
                 }
             }
@@ -623,7 +623,7 @@ internal static void RestoreRenderPipelineAsset(bool wasUnsetFromQuality, Render
             }
             else
             {
-                GraphicsSettings.renderPipelineAsset = renderPipelineAsset;
+                GraphicsSettings.defaultRenderPipeline = renderPipelineAsset;
             }
         }
 

Packages/com.unity.render-pipelines.universal/Editor/Lighting/UniversalRenderPipelineLightUI.Drawers.cs

@@ -474,7 +474,7 @@ static void DrawShadowsResolutionGUI(UniversalRenderPipelineSerializedLight seri
                     }
                     else
                     {
-                        if (GraphicsSettings.renderPipelineAsset is UniversalRenderPipelineAsset urpAsset)
+                        if (GraphicsSettings.currentRenderPipeline is UniversalRenderPipelineAsset urpAsset)
                             EditorGUILayout.LabelField($"{urpAsset.GetAdditionalLightsShadowResolution(shadowResolutionTier)} ({urpAsset.name})", GUILayout.ExpandWidth(false));
                     }
                     if (checkScope.changed)

Packages/com.unity.render-pipelines.universal/Editor/RendererFeatures/ScreenSpaceAmbientOcclusionEditor.cs

@@ -132,8 +132,8 @@ public override void OnInspectorGUI()
 
         private bool RendererIsDeferred()
         {
-            ScreenSpaceAmbientOcclusion ssaoFeature = (ScreenSpaceAmbientOcclusion)this.target;
-            UniversalRenderPipelineAsset pipelineAsset = (UniversalRenderPipelineAsset)GraphicsSettings.renderPipelineAsset;
+            ScreenSpaceAmbientOcclusion ssaoFeature = (ScreenSpaceAmbientOcclusion) target;
+            UniversalRenderPipelineAsset pipelineAsset = (UniversalRenderPipelineAsset) GraphicsSettings.currentRenderPipeline;
 
             if (ssaoFeature == null || pipelineAsset == null)
                 return false;
@@ -142,14 +142,14 @@ private bool RendererIsDeferred()
             var rendererDataList = pipelineAsset.m_RendererDataList;
             for (int rendererIndex = 0; rendererIndex < rendererDataList.Length; ++rendererIndex)
             {
-                ScriptableRendererData rendererData = (ScriptableRendererData)rendererDataList[rendererIndex];
-                if (rendererData == null)
+                var rendererData = rendererDataList[rendererIndex] as UniversalRendererData;
+                if (rendererData == null || rendererData.renderingMode != RenderingMode.Deferred)
                     continue;
 
                 var rendererFeatures = rendererData.rendererFeatures;
                 foreach (var feature in rendererFeatures)
-                    if (feature is ScreenSpaceAmbientOcclusion && (ScreenSpaceAmbientOcclusion)feature == ssaoFeature)
-                        return rendererData is UniversalRendererData && ((UniversalRendererData)rendererData).renderingMode == RenderingMode.Deferred;
+                    if (feature is ScreenSpaceAmbientOcclusion occlusion && occlusion == ssaoFeature)
+                        return true;
             }
 
             return false;

Packages/com.unity.render-pipelines.universal/Samples~/URPPackageSamples/SharedAssets/Scripts/CheckAssignedRenderPipelineAsset.cs

@@ -12,7 +12,7 @@ public class CheckAssignedRenderPipelineAsset : MonoBehaviour
     private bool m_LastCorrectPipelineResults = false;
 
     private bool isCorrectAssetAssigned => QualitySettings.renderPipeline == m_PipelineAsset
-                                           || QualitySettings.renderPipeline == null && GraphicsSettings.renderPipelineAsset == m_PipelineAsset;
+                                           || QualitySettings.renderPipeline == null && GraphicsSettings.defaultRenderPipeline == m_PipelineAsset;
 
     private void Awake()
     {