Commit 5dae334
[HDRP] Fix lens flare screen space and bloom frame settings confusion.
In [this forum post](https://forum.unity.com/threads/disabling-post-processing-effects-in-the-default-volume-profile.1545362/#post-9891525), a user complained that even if Bloom frame settings was set to false, if there was a screen space lens flare override, we "reactivated" the bloom pass without the user's knowledge which can be confusing and deceiving.
Now, SSLF frame settings is now a child of the Bloom frame settings. In addition, there's a warning box directly in the override if any of the frame setting (bloom or SSLF) is set to false preventing the bloom pass to be executed without the users knowledge.

In addition, since SSLF writes directly on the bloom buffer and uses the uberpass bloom to be rendered, if bloom intensity is set to zero, it won't render. So in the SSLF override there's now a message warning you that one or more bloom override prevents SSLF to be rendered.

Lastly, I took the opportunity with this PR to add the frame settings check wherever it made sense in the current override to avoid further users confusions (cf [commit](https://github.cds.internal.unity3d.com/unity/unity/pull/51061/commits/32f1369d6710394879f23d2f24f84b73a68710cb)).1 parent 0563fc9 commit 5dae334
27 files changed
Lines changed: 111 additions & 16 deletions
File tree
- Packages/com.unity.render-pipelines.high-definition
- Editor
- Lighting
- Reflection
- Shadow
- VolumetricClouds
- PostProcessing
- RenderPipeline
- LineRendering
- PathTracing
- Raytracing
- Sky/AtmosphericScattering
- Water
- Runtime/RenderPipeline
- Settings
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| 191 | + | |
| 192 | + | |
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
| 121 | + | |
120 | 122 | | |
121 | 123 | | |
122 | 124 | | |
| |||
Packages/com.unity.render-pipelines.high-definition/Editor/Lighting/Shadow/ContactShadowsEditor.cs
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
43 | 45 | | |
44 | 46 | | |
45 | 47 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
507 | 507 | | |
508 | 508 | | |
509 | 509 | | |
| 510 | + | |
| 511 | + | |
510 | 512 | | |
511 | 513 | | |
512 | 514 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
42 | 44 | | |
43 | 45 | | |
44 | 46 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
0 commit comments