[HDRP] Fix error when using light dimmer

Fix error in the console when using light dimmer

Author: adrien-de-tocqueville

Packages/com.unity.render-pipelines.high-definition/Runtime/Lighting/LightLoop/LightLoop.cs

@@ -1389,11 +1389,10 @@ void PreprocessVisibleLights(ScriptableRenderContext renderContext, CommandBuffe
 
                     if (hdCamera.visualSky.skyRenderer?.GetType() == typeof(PhysicallyBasedSkyRenderer))
                     {
-                        // Lights with 0 intensity are culled by unity, but we still want to show them
-                        // in the PBR sky, so we need to allocate space for the cookie
+                        // Allocate space in the cookie atlas for PBR sky surface textures
                         foreach (var directional in lightEntities.directionalLights)
                         {
-                            if (directional.legacyLight.intensity == 0.0f && directional.interactsWithSky)
+                            if (directional.interactsWithSky)
                                 m_TextureCaches.lightCookieManager.ReserveSpace(directional.surfaceTexture);
                         }
                     }
@@ -1773,8 +1772,6 @@ internal void ReserveCookieAtlasTexture(HDAdditionalLightData hdLightData, Light
             {
                 case LightType.Directional:
                 {
-                    if (hdLightData.interactsWithSky)
-                        m_TextureCaches.lightCookieManager.ReserveSpace(hdLightData.surfaceTexture);
                     m_TextureCaches.lightCookieManager.ReserveSpace(light?.cookie);
                     break;
                 }

Packages/com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSky.cs

@@ -168,11 +168,11 @@ public enum RenderingMode
 
         /// <summary> Horizon tint. Does not affect the precomputation. </summary>
         [Tooltip("Specifies a color that HDRP uses to tint the sky at the horizon. Does not affect the precomputation.")]
-        public ColorParameter horizonTint = new ColorParameter(Color.white, hdr: false, showAlpha: false, showEyeDropper: false);
+        public ColorParameter horizonTint = new ColorParameter(Color.white, hdr: false, showAlpha: false, showEyeDropper: true);
 
         /// <summary> Zenith tint. Does not affect the precomputation. </summary>
         [Tooltip("Specifies a color that HDRP uses to tint the point in the sky directly above the observer (the zenith). Does not affect the precomputation.")]
-        public ColorParameter zenithTint = new ColorParameter(Color.white, hdr: false, showAlpha: false, showEyeDropper: false);
+        public ColorParameter zenithTint = new ColorParameter(Color.white, hdr: false, showAlpha: false, showEyeDropper: true);
 
         /// <summary> Horizon-zenith shift. Does not affect the precomputation. </summary>
         [Tooltip("Controls how HDRP blends between the Horizon Tint and Zenith Tint. Does not affect the precomputation.")]

Packages/com.unity.render-pipelines.high-definition/Runtime/Sky/PhysicallyBasedSky/PhysicallyBasedSkyRenderer.cs

@@ -311,6 +311,7 @@ public void BindBuffers(MaterialPropertyBlock mpb)
 
         static PrecomputationCache s_PrecomputationCache = new PrecomputationCache();
 
+        const int k_MaxCelestialBodies = 16;
         static GraphicsBuffer s_CelestialBodyBuffer;
         static CelestialBodyData[] s_CelestialBodyData;
         static int s_DataFrameUpdate = -1;
@@ -408,7 +409,6 @@ void UpdateCelestialBodyBuffer(CommandBuffer cmd, BuiltinSkyParameters builtinPa
         {
             if (s_CelestialBodyBuffer == null)
             {
-                int k_MaxCelestialBodies = 16;
                 int stride = System.Runtime.InteropServices.Marshal.SizeOf(typeof(CelestialBodyData));
                 s_CelestialBodyBuffer = new GraphicsBuffer(GraphicsBuffer.Target.Structured, k_MaxCelestialBodies, stride);
                 s_CelestialBodyData = new CelestialBodyData[k_MaxCelestialBodies];
@@ -428,12 +428,14 @@ void UpdateCelestialBodyBuffer(CommandBuffer cmd, BuiltinSkyParameters builtinPa
                     {
                         FillCelestialBodyData(cmd, light, ref s_CelestialBodyData[lightCount++]);
                         exposure = Mathf.Max(light.legacyLight.intensity * -light.transform.forward.y, exposure);
+                        if (lightCount >= k_MaxCelestialBodies) break;
                     }
                 }
 
                 uint bodyCount = lightCount;
                 foreach (var light in directionalLights)
                 {
+                    if (bodyCount >= k_MaxCelestialBodies) break;
                     if (light.legacyLight.enabled && light.interactsWithSky && light.legacyLight.intensity == 0.0f)
                         FillCelestialBodyData(cmd, light, ref s_CelestialBodyData[bodyCount++]);
                 }