Graphics/SRP/RPF - [UUM-57147] - Disabling NRP for Editor FinalCopyDepth pass

This PR disables Native Render Pass (NRP) support of URP Editor-only `FinalCopyDepth` pass which is used a pre-step for the Post-Process Gizmos pass in URP 3D. Using NRP in this pass triggered a corner case which is not well covered by NRP pipeline in Compatibility mode. Indeed, NRP pipeline begins a native render pass with a number of MSAA samples taken from the `CameraTargetDescriptor`. `CameraTargetDescriptor` seems to obtain that information from the RenderPipeline asset, so depending on what users select in the UI, it can be no MSAA/x2/x4/x8. On the other hand, `FinalCopyDepth` seems to be the only pass targeting `k_CameraTarget` in URP 3D and its attachment (backbuffer) has no MSAA enabled, triggering a mismatch in NRP validation layer as the number of samples is different (unacceptable in NRP). As this is Editor only + Compatibility mode, I assume that using NRP for this pass is not really important and can be disabled. Compatibility mode with no NRP works fine for this case.

Note that NRP Render Graph should be preferred over NRP Compatibility mode for Unity 6.

Author: axoloto

Packages/com.unity.render-pipelines.universal/Runtime/Passes/CopyDepthPass.cs

@@ -72,16 +72,8 @@ public void Dispose()
         [Obsolete(DeprecationMessage.CompatibilityScriptingAPIObsolete, false)]
         public override void OnCameraSetup(CommandBuffer cmd, ref RenderingData renderingData)
         {
-            var descriptor = renderingData.cameraData.cameraTargetDescriptor;
-            var isDepth = (destination.rt && destination.rt.graphicsFormat == GraphicsFormat.None);
-            descriptor.graphicsFormat = isDepth ? GraphicsFormat.D32_SFloat_S8_UInt : GraphicsFormat.R32_SFloat;
-            descriptor.msaaSamples = 1;
-
             // Disable obsolete warning for internal usage
             #pragma warning disable CS0618
-
-            // This is a temporary workaround for Editor as not setting any depth here
-            // would lead to overwriting depth in certain scenarios (reproducable while running DX11 tests)
 #if UNITY_EDITOR
             // This is a temporary workaround for Editor as not setting any depth here
             // would lead to overwriting depth in certain scenarios (reproducable while running DX11 tests)

Packages/com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs

@@ -357,7 +357,7 @@ public UniversalRenderer(UniversalRendererData data) : base(data)
             m_FinalBlitPass = new FinalBlitPass(RenderPassEvent.AfterRendering + k_FinalBlitPassQueueOffset, m_BlitMaterial, m_BlitHDRMaterial);
 
 #if UNITY_EDITOR
-            m_FinalDepthCopyPass = new CopyDepthPass(RenderPassEvent.AfterRendering + 9, copyDephPS);
+            m_FinalDepthCopyPass = new CopyDepthPass(RenderPassEvent.AfterRendering + 9, copyDephPS, false, true);
             if (GraphicsSettings.TryGetRenderPipelineSettings<UniversalRenderPipelineDebugShaders>(out var debugShaders))
                 m_ProbeVolumeDebugPass = new ProbeVolumeDebugPass(RenderPassEvent.BeforeRenderingTransparents, debugShaders.probeVolumeSamplingDebugComputeShader);
 #endif
@@ -1471,8 +1471,11 @@ public override void Setup(ScriptableRenderContext context, ref RenderingData re
             {
                 // Scene view camera should always resolve target (not stacked)
                 m_FinalDepthCopyPass.Setup(m_DepthTexture, k_CameraTarget);
-                m_FinalDepthCopyPass.CopyToDepth = true;
                 m_FinalDepthCopyPass.MssaSamples = 0;
+                // Turning off unnecessary NRP in Editor because of MSAA mistmatch between CameraTargetDescriptor vs camera backbuffer
+                // NRP layer considers this being a pass with MSAA samples by checking CameraTargetDescriptor taken from RP asset
+                // while the camera backbuffer has a single sample
+                m_FinalDepthCopyPass.useNativeRenderPass = false; 
                 EnqueuePass(m_FinalDepthCopyPass);
             }
 #endif

Packages/com.unity.render-pipelines.universal/Runtime/UniversalRendererRenderGraph.cs

@@ -1436,7 +1436,6 @@ private void OnAfterRendering(RenderGraph renderGraph)
             if (cameraData.isSceneViewCamera || cameraData.isPreviewCamera || (isGizmosEnabled && cameraData.resolveFinalTarget))
             {
                 TextureHandle cameraDepthTexture = resourceData.cameraDepthTexture;
-                m_FinalDepthCopyPass.CopyToDepth = true;
                 m_FinalDepthCopyPass.MssaSamples = 0;
                 m_FinalDepthCopyPass.Render(renderGraph, frameData, resourceData.activeDepthTexture, cameraDepthTexture, false, "Final Depth Copy");
             }