Fix ordering of applying styles#725
Draft
cvanelteren wants to merge 3 commits into
Draft
Conversation
…oss repeated format calls without freezing theme defaults, and route generic format aliases consistently through subplot and figure formatting paths. This fixes the dark-mode regressions on alternate axes, restores polar frame styling after the shared helper split, and adds regression coverage for persistence, clearing overrides, and theme transitions.
…n formatting all derive their generic alias handling from one shared schema instead of repeated manual key lists. This keeps the explicit override model intact while making format-key dispatch and persistence much easier to maintain as new axis styling options are added.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework axis formatting so explicit axis and tick styling persists across repeated format calls without freezing theme defaults, and route generic format aliases consistently through subplot and figure formatting paths. This fixes the dark-mode regressions on alternate axes, restores polar frame styling after the shared helper split, and adds regression coverage for persistence, clearing overrides, and theme transitions.