fix: selectFrames(1, ...) drops the guaranteed wildcard frame - #60
Open
UditAkhourii wants to merge 1 commit into
Open
UditAkhourii wants to merge 1 commit into
UditAkhourii wants to merge 1 commit into
Conversation
Reserve the wildcard slot before sampling the rest of the pool instead of appending it after slicing to n, which silently dropped it whenever n=1 and the first random pick wasn't already the wildcard (~50% of the time). Adds a regression test asserting selectFrames(1, ...) always returns a wildcard-tagged frame. Closes #43 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectFramespickedn - 1frames first, then pushed the wildcard and sliced back ton— atn=1this threw the wildcard away whenever the first random pick wasn't already the wildcard (~50% of the time).n. Behavior forn > 1is unchanged (wildcard still guaranteed, rest still uniformly shuffled from the pool).Testing
tests/frames.test.ts: assertsselectFrames(1, ...)always returns a wildcard-tagged frame (50 iterations), and thatselectFrames(n, ...)forn > 1still includes at least one wildcard frame while returning exactlynframes.npm test— all tests pass (3/3).npm run typecheck— clean.Closes #43
🤖 Generated with Claude Code