Add servoing - #4
Open
NotNotQuinn wants to merge 7 commits into
Open
Conversation
We need 4D at least for the gripper to be flat when moving up and down
Sends two separate messages to move the gripper, and then change the pitch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently servoing is working.
Some notes:
ros2 service call /servo_node/start_servo std_srvs/srv/Trigger {}after starting the node otherwise it will silently do nothing. (how convenient)+/- 7e-5 mwith a warning about decelerating for collision and/or singularity. Likely self-collision.publish_periodwas heavily increased (reducing the rate), as when it was set to the example's value the IK for one servo command wouldn't finish before the next being sent, leading to no movement at all except for the final command when you stop command a movement.joystick.yamlbefore commiting, but currently the control is quite unintuitive (left -> go forward, I think)The next things I think are important to focus on: (in different PRs)