Skip to content

default topphatt - #206

Merged
MIWdlB merged 1 commit into
mainfrom
default-topphatt
Jul 8, 2026
Merged

default topphatt#206
MIWdlB merged 1 commit into
mainfrom
default-topphatt

Conversation

@MIWdlB

@MIWdlB MIWdlB commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Topphatt performance is now so good that it can be the default encoding. For systems with >100 modes, it'll start to take a noticeable amount of time. Can cross that bridge once QPUs are big enough to need it.

  • encode_topphatt -> encode
  • encode -> encode_naive

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MIWdlB
MIWdlB merged commit 46230f7 into main Jul 8, 2026
4 checks passed
@MIWdlB
MIWdlB deleted the default-topphatt branch July 8, 2026 12:36
@codspeed-hq

codspeed-hq Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 19%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 12 regressed benchmarks
✅ 44 untouched benchmarks
⏩ 100 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation test_benchmark_encode_naive[h2_6-31g-JordanWigner] 3 ms 4 ms -26.36%
Simulation test_benchmark_encode_naive[h2o_sto-3g-JKMN] 34 ms 43.3 ms -21.53%
Simulation test_benchmark_encode_naive[h2_6-31g-JKMN] 3 ms 3.8 ms -21.51%
Simulation test_benchmark_encode_naive[h2_6-31g-Parity] 3 ms 3.8 ms -20.77%
Simulation test_benchmark_encode_naive[h2_6-31g-BravyiKitaev] 3 ms 3.7 ms -20.17%
Simulation test_benchmark_encode_naive[h2o_6-31g-JKMN] 503.3 ms 627.3 ms -19.77%
Simulation test_benchmark_encode_naive[h2o_sto-3g-Parity] 33.9 ms 41.6 ms -18.39%
Simulation test_benchmark_encode_naive[h2o_sto-3g-JordanWigner] 34.2 ms 41.5 ms -17.5%
Simulation test_benchmark_encode_naive[h2o_sto-3g-BravyiKitaev] 34 ms 40.6 ms -16.17%
Simulation test_benchmark_encode_naive[h2o_6-31g-Parity] 503.3 ms 593.2 ms -15.17%
Simulation test_benchmark_encode_naive[h2o_6-31g-JordanWigner] 501.8 ms 590.3 ms -14.99%
Simulation test_benchmark_encode_naive[h2o_6-31g-BravyiKitaev] 503.5 ms 591 ms -14.79%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing default-topphatt (edbbb96) with main (74bd8a2)

Open in CodSpeed

Footnotes

  1. 100 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant