Potential fix for code scanning alert no. 291: Missing call to superclass __init__ during object initialization - #505
Draft
DavidPCoster wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 291: Missing call to superclass __init__ during object initialization#505DavidPCoster wants to merge 1 commit into
__init__ during object initialization#505DavidPCoster wants to merge 1 commit into
Conversation
…lass `__init__` during object initialization Not sure if this is really necessary ... Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UCL-CCS/EasyVVUQ/security/code-scanning/291
General fix: in any subclass
__init__, call the parent initializer (super().__init__(...)) so base-class state is initialized.Best minimal fix here: update
GaussianProcessSurrogateResults.__init__insrc/easyvvuq/analysis/gp_analyse.pyto invokesuper().__init__()before assigning subclass fields. This preserves existing functionality while ensuringAnalysisResultsinitialization is not skipped. No imports or new helper methods are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.