Potential fix for code scanning alert no. 293: Use of exit() or quit() - #496
Draft
DavidPCoster wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 293: Use of exit() or quit()#496DavidPCoster wants to merge 1 commit into
DavidPCoster wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
djgroen
approved these changes
Aug 11, 2026
DavidPCoster
requested review from
cspgdds and
mzrghorbani
and removed request for
cspgdds and
mzrghorbani
August 13, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UCL-CCS/EasyVVUQ/security/code-scanning/293
Use
sys.exit()instead ofexit()and ensuresysis imported insrc/easyvvuq/sampling/fd.py.Best minimal fix (no functionality change):
import sysnear the existing imports.exit()in the error branch insidegenerate_nodes(...)withsys.exit().This preserves current behavior (terminating execution on this critical internal state) while removing dependence on
site.Quitter.Suggested fixes powered by Copilot Autofix. Review carefully before merging.