Potential fix for code scanning alert no. 294: Use of exit() or quit() - #495
Draft
DavidPCoster wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 294: Use of exit() or quit()#495DavidPCoster wants to merge 1 commit into
DavidPCoster wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UCL-CCS/EasyVVUQ/security/code-scanning/294
Replace
exit()withsys.exit(...)and add a standard-libraryimport sysat the top ofsrc/easyvvuq/sampling/pce.py.Best minimal fix without changing intended behavior:
import sys.exit()withsys.exit(1)(non-zero status indicates error, matching the existing logging of an unsupported argument type).This keeps functionality the same (terminate on unsupported type) while removing reliance on
site.Quitter.Suggested fixes powered by Copilot Autofix. Review carefully before merging.