Skip to content

feat: rule/status filters, refresh failure banner, selectable a11y, and dashboard now memoization - #326

Merged
Valreb001 merged 2 commits into
Tx-wats:mainfrom
levibliz:feat/filter-refresh-a11y-dashboard-memo
Oct 19, 2026
Merged

Valreb001 merged 2 commits into
Tx-wats:mainfrom
levibliz:feat/filter-refresh-a11y-dashboard-memo

Conversation

@levibliz

Copy link
Copy Markdown
Contributor

Description

This PR addresses issues #220, #219, #218, and #217:

  1. Dashboard now Memoization (now Computed on Every Render Defeats the Dashboard's useMemo #220):
    • Holds now in state and updates it on a 60-second interval as well as on alert changes via onAlertsChange.
    • Prevents re-renders from redundantly recomputing daily and hourly bucket series.
  2. Filter Contracts by Rule Type and Paused State (Filter Contracts by Rule Type and Paused State #219):
    • Adds multi-select chips for all alert rule types (LargeTransfer, AdminFunctionCalled, AnyTransaction, FunctionCalled, TransactionFailed).
    • Adds status segmented control for All, Active, and Paused contracts.
    • Synchronizes filter parameters (network, status, ruleTypes, q, sort, view) to the URL search parameters.
  3. Surface Contract Refresh Failures in API Mode (Surface Contract Refresh Failures in API Mode #218):
    • Shows a subtle "Refreshing…" indicator during background sync on first load.
    • Renders a dismissible warning banner when refreshContracts() fails to reach the core API, indicating cached contracts are displayed with the reason and providing a Retry button.
  4. Accessible Selection Mode for ContractCard (Selectable Contract Card Nests a Checkbox Inside role="button" #217):
    • Replaces div role="button" in selectable mode with a semantic <label> container wrapping the <input type="checkbox">.
    • Eliminates nested-interactive violations reported by accessibility tools and fixes double-toggling on Space key press.

Closes #220
Closes #219
Closes #218
Closes #217

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@levibliz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Valreb001
Valreb001 merged commit 17d28ac into Tx-wats:main Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants