Repository navigation
feat(notifier): Slack limits and link escaping, resolved/details in chat formats, Teams format - #355
Merged
Valreb001 merged 1 commit intoOct 21, 2026
Conversation
…ormat - Enforce Slack Block Kit limits (3000/2000 chars, max 10 fields) - Escape URLs inside Slack link markup - Add resolved headline variant and source/ledger/memo/severity/ suppressed/matched-event details to chat formats - Add format = "teams" rendering an Adaptive Card payload Closes Tx-wats#302 Closes Tx-wats#303 Closes Tx-wats#304 Closes Tx-wats#305
|
@gadst12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<url|text>links are escaped:&becomes&, and<,>and|are percent-encoded. Link text is mrkdwn-escaped. This applies to the alert message, its context links and the digest.format = "teams", which renders an Adaptive Card 1.4 message. A batch is sent as one digest card. Documented indocs/configuration.mdand added to the JSON schema.Closes #302
Closes #303
Closes #304
Closes #305
Validation
rustfmtpasses on the changed Rust files.mainalready fails to build.crates/config/src/lib.rs:617has an unclosedAlertRuleReprenum, and the test fixture informat.rsrepeats several fields. Both problems predate this PR and are left unchanged.