Repository navigation
fix(#222-225): hash validation, deliver_alert, webhook status, passph… - #351
Merged
Merged
Conversation
… passphrase check Tx-wats#222 – validate_tx_hash(): require 64 hex chars, strip optional 0x prefix; updated TX_HASH in replay tests to a valid 64-char hex string. Tx-wats#223 – expose deliver_alert() from txwatch-poller so replay --send uses the same rule-level URL/secret routing and destination filtering as watch; added per-rule routing test. Tx-wats#224 – check_webhook_reachable() now reports actual HTTP status codes (e.g. 'HTTP 404', 'HTTP 500') instead of the generic 'method not allowed'; treats 401/403 as 'reachable (auth required)'; removed redundant if err.is_builder() branch whose arms were identical. Tx-wats#225 – Network::expected_passphrase() returns the known passphrase for named networks and the configured one for custom networks; check_horizon_contract compares Horizon's network_passphrase against this and fails on mismatch. Updated .gitignore to exclude test snapshots (*.snap, snapshots/), temp files, and common editor/OS noise.
|
@kurehkim334-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rase check
#222 – validate_tx_hash(): require 64 hex chars, strip optional 0x prefix;
updated TX_HASH in replay tests to a valid 64-char hex string.
#223 – expose deliver_alert() from txwatch-poller so replay --send uses the
same rule-level URL/secret routing and destination filtering as watch;
added per-rule routing test.
#224 – check_webhook_reachable() now reports actual HTTP status codes (e.g.
'HTTP 404', 'HTTP 500') instead of the generic 'method not allowed';
treats 401/403 as 'reachable (auth required)'; removed redundant
if err.is_builder() branch whose arms were identical.
#225 – Network::expected_passphrase() returns the known passphrase for named
networks and the configured one for custom networks; check_horizon_contract
compares Horizon's network_passphrase against this and fails on mismatch.
Updated .gitignore to exclude test snapshots (*.snap, snapshots/), temp files, and common editor/OS noise.
Summary
Changes
Checklist
docs/configuration.md/README.mdfor any config or payload changedocs/txwatch-config.schema.jsonviatxwatch schemaif the config schema changed## [Unreleased]inCHANGELOG.mdNotes
closes
close #222
close #223
close #224
close #225