Repository navigation
fix: resolve issues #234, #235, #236, #237 - #348
Merged
Merged
Conversation
- Tx-wats#234: add match_mode field to FunctionCalled TOML repr so prefix/glob matching is reachable from config files; pass it through in the AlertRule conversion instead of hardcoding the default; add parse tests for all three modes (exact, prefix, glob); correct docs/alert-rules.md field name from 'match' to 'match_mode' - Tx-wats#235: expand resolve_env_vars to interpolate webhooks[].url, soroban_rpc_url, and network.rpc_url; add resolve_rule_entry helper that recursively interpolates rule-level webhook_url/webhook_secret inside All/Any/Not composite rules; add per-field tests; update docs/configuration.md interpolated-fields list - Tx-wats#236: add summary_interval_seconds to AppConfig (default 60, 0 = disabled); add default_summary_interval_seconds fn; update config/example.toml comment to note the default; add parse tests for default, zero, and custom values; document the field in docs/configuration.md top-level fields table - Tx-wats#237: fix SourceAccount example in config/example.toml — the comment said 'alert when called by anyone except the known admin' but the rule used deny=[admin] which fires only when the admin calls; remove the unnecessary All wrapper; add clear allow-vs-deny commentary explaining both semantics and how to express 'alert on everyone except X' - .gitignore: exclude test snapshots (*.snap, *.snap.new), IDE dirs (.idea/, .vscode/, *.iml), OS artefacts (.DS_Store, Thumbs.db) and environment/secret files (.env, .env.*)
|
@cephas360 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionCalled.match_modeCannot Be Set From TOML #234: add match_mode field to FunctionCalled TOML repr so prefix/glob matching is reachable from config files; pass it through in the AlertRule conversion instead of hardcoding the default; add parse tests for all three modes (exact, prefix, glob); correct docs/alert-rules.md field name from 'match' to 'match_mode'${VAR}Interpolation Skips Several URL and Secret Fields #235: expand resolve_env_vars to interpolate webhooks[].url, soroban_rpc_url, and network.rpc_url; add resolve_rule_entry helper that recursively interpolates rule-level webhook_url/webhook_secret inside All/Any/Not composite rules; add per-field tests; update docs/configuration.md interpolated-fields listexample.tomlAdvertises asummary_interval_secondsSetting That Does Not Exist #236: add summary_interval_seconds to AppConfig (default 60, 0 = disabled); add default_summary_interval_seconds fn; update config/example.toml comment to note the default; add parse tests for default, zero, and custom values; document the field in docs/configuration.md top-level fields tableexample.tomlDescribes theSourceAccountExample Backwards #237: fix SourceAccount example in config/example.toml — the comment said 'alert when called by anyone except the known admin' but the rule used deny=[admin] which fires only when the admin calls; remove the unnecessary All wrapper; add clear allow-vs-deny commentary explaining both semantics and how to express 'alert on everyone except X'.gitignore: exclude test snapshots (*.snap, *.snap.new), IDE dirs (.idea/, .vscode/, .iml), OS artefacts (.DS_Store, Thumbs.db) and environment/secret files (.env, .env.)
Checklist
docs/configuration.md/README.mdfor any config or payload changedocs/txwatch-config.schema.jsonviatxwatch schemaif the config schema changed## [Unreleased]inCHANGELOG.mdNotes
closes #234
closes #235
closes #236
closes #237