Repository navigation
ui(home): on laptops the live line is the locker's caption - #80
Conversation
The hero's closing "Latest" line was a bar across the whole content width, its label on the far left and its age on the far right, under both columns. From 1024px it now sits right under the locker frame, as wide as the frame, and the frame and the line center together in the locker's column. Phones and tablets are unchanged to the pixel (the line is still the grid's last row, with the same spacing). - LaunchHero: the stage is wrapped in a column holding it and a second rendering of the line; one rendering is shown per size (display:none on the other, so nothing reads or tabs through it twice) - the grid loses its third row from 1024px, so the hero is 60px shorter on laptops and the Trending heading starts 60px higher - the loading skeleton mirrors it; the hero-height parity with the skeleton is unchanged (it was always 1-2px short) - tests: contracts for both renderings and the grid areas per size
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe hero ticker now renders in the stage column at desktop widths and in a full-width grid row at smaller widths. The loading skeleton follows the same placement. The layout contract and tests were updated, and the former ChangesHero ticker layout
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The responsive ticker and loading skeleton follow the intended placements, with no material regression established. The change is mergeable subject to normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
1 participant
The hero's closing "Latest" line was a bar across the whole content width, its label on the far left and its age on the far right, under both columns. From 1024px it now sits right under the locker frame, as wide as the frame, and the frame and the line center together in the locker's column. Phones and tablets are unchanged to the pixel (the line is still the grid's last row, with the same spacing).
Summary by CodeRabbit