Skip to content

Align engines, CI and README with the Node 26 line - #874

Merged
aileen merged 2 commits into
mainfrom
repo-audit/node-26-alignment
Oct 29, 2026
Merged

aileen merged 2 commits into
mainfrom
repo-audit/node-26-alignment

Conversation

@aileen

@aileen aileen commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #872. .nvmrc is local-dev only and moves independently; engines.node and CI track the latest Node LTS — Node 26, LTS since 2026-10-28.

  • engines.node: ^26.13.0 (caret range on the LTS baseline, matching Ghost core's engines style)
  • CI matrix: 26.13.0 (latest LTS release; Renovate keeps it current)
  • README install requirement states the LTS line

CI on this PR proves the suite (271 tests incl. CLI/module smoke) on Node 26.

Renovate's .nvmrc bump to 26.13.0 (#872) only moved one of the four
places that name a Node version, leaving engines, the CI matrix and
the README install requirement on 22.21.1 - so the version developers
were told to use was not the one CI tested. This restores lockstep
across all four, with CI now proving the suite on Node 26.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: cb1c2f93-1b24-49cd-90da-3e4a63f0b380
Commits

Reviewing files that changed from the base of the PR and between 05821d0 and 5e67b4b.

Files selected for processing: 2
  • README.md
  • package.json

Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The package engine requirement and README now specify Node.js ^26.13.0. The CI build matrix now uses Node.js 26.13.0.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related issues

  • Dependency Dashboard #77: This PR updates the Node.js requirement and aligns it with the CI version described in the issue.

Possibly related PRs

Suggested reviewers: pauladamdavis

Merge Risk: Minimal · up to 5e67b

The Node.js version requirements and CI alignment introduce no established merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the Node.js 26 updates to engines.node, CI, and README, and provides the stated testing context.
Title check Passed The title clearly summarizes the main change: aligning engines, CI, and README with Node.js 26.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

.nvmrc is a local-dev convenience and moves independently; engines and
CI track the latest Node LTS (26, LTS since 2026-10-28). Caret range on
the LTS baseline matches Ghost core's engines style.
@aileen
aileen merged commit 4a07fb4 into main Oct 29, 2026
6 checks passed
@aileen
aileen deleted the repo-audit/node-26-alignment branch October 29, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant