Skip to content

Document milestone status/evidence freeze on terminal states - #14

Merged
techrebelgit merged 1 commit into
mainfrom
docs/status-freeze-terminal-states
Sep 27, 2026
Merged

techrebelgit merged 1 commit into
mainfrom
docs/status-freeze-terminal-states

Conversation

@armandocodecr

Copy link
Copy Markdown
Contributor

The contracts now reject change-milestone-status once the state is terminal, on all four branches:

  • Single-release (v1 22a0b23, v2 63123eb): rejected when the escrow is released or its dispute resolved (EscrowAlreadyReleased / EscrowAlreadyResolved; codes 16/17 in v2's MilestoneError).
  • Multi-release (v1 887182a, v2 edaa4a7): rejected per milestone once it is released or its dispute resolved (MilestoneAlreadyReleased / MilestoneAlreadyResolved).

Updates stay allowed while a dispute is open — deliberate: fresh evidence can help resolve it.

Doc updates: protocol profiles (v1.md law 4, v2.md new ENFORCED block) and the change-milestone-status sections of all four API references. The v1 notes carry the lineage date since deployments predating the commits do not enforce the rule.

Consistency checks pass.

🤖 Generated with Claude Code

Status and evidence stay editable while a dispute is open but are
rejected once the escrow (single) or milestone (multi) is released
or resolved. Applies to both protocol versions; v1 notes the lineage
date since prior deployments do not enforce it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f114f1e7-8aaf-45e9-9cad-2cbe67f019a2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor

Reviewed against the underlying Stellar contract changes for all four lineages (V1/V2 × single/multi release). The documented terminal-state freeze, the deliberate allowance for status/evidence updates while a dispute remains open, and the V1 lineage caveat all match the implementation. No content blockers found.

The Docs consistency Action is currently reporting failure, but the failed job shows zero executed steps, so this appears to be a CI/runner issue rather than a consistency-script finding. Proceeding with merge.

@techrebelgit techrebelgit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against the underlying V1/V2 single- and multi-release contract changes. Documentation matches implementation, including terminal-state immutability, open-dispute evidence updates, and the V1 lineage caveat.

@techrebelgit
techrebelgit merged commit ad7d896 into main Sep 27, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants