Repository navigation
Document milestone status/evidence freeze on terminal states - #14
Conversation
Status and evidence stay editable while a dispute is open but are rejected once the escrow (single) or milestone (multi) is released or resolved. Applies to both protocol versions; v1 notes the lineage date since prior deployments do not enforce it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed against the underlying Stellar contract changes for all four lineages (V1/V2 × single/multi release). The documented terminal-state freeze, the deliberate allowance for status/evidence updates while a dispute remains open, and the V1 lineage caveat all match the implementation. No content blockers found. The |
techrebelgit
left a comment
There was a problem hiding this comment.
Reviewed against the underlying V1/V2 single- and multi-release contract changes. Documentation matches implementation, including terminal-state immutability, open-dispute evidence updates, and the V1 lineage caveat.
The contracts now reject
change-milestone-statusonce the state is terminal, on all four branches:22a0b23, v263123eb): rejected when the escrow isreleasedor its disputeresolved(EscrowAlreadyReleased/EscrowAlreadyResolved; codes 16/17 in v2'sMilestoneError).887182a, v2edaa4a7): rejected per milestone once it isreleasedor its disputeresolved(MilestoneAlreadyReleased/MilestoneAlreadyResolved).Updates stay allowed while a dispute is open — deliberate: fresh evidence can help resolve it.
Doc updates: protocol profiles (v1.md law 4, v2.md new ENFORCED block) and the change-milestone-status sections of all four API references. The v1 notes carry the lineage date since deployments predating the commits do not enforce the rule.
Consistency checks pass.
🤖 Generated with Claude Code