fix(test): restore full suite projection bootstrap - #99
Conversation
yordis
commented
Apr 29, 2026
- keep projection and Ecto test coverage trustworthy by creating the tables those suites actually depend on
- prevent suite-only regressions caused by projection setup differing between isolated runs and full
- make the dispatcher retry OTel test resilient to unrelated span exports so full-suite results reflect real regressions instead of export ordering
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryCursor Bugbot is generating a summary for commit 05efd7c. Configure here. |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughTwo test infrastructure improvements: refactoring telemetry span collection in dispatcher retry tests to use continuous message receiving instead of fixed-count collection, and adding SQL-based provisioning for a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 31 minutes and 45 seconds.Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 05efd7c. Configure here.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/opentelemetry/dispatcher_retry_test.exs`:
- Around line 95-126: The helper collect_retry_spans/1 currently returns the
first dispatch and execute spans seen even if they belong to different traces or
commands; update the matching logic in collect_retry_spans(dispatch_span,
execute_span, seen, deadline) (and its helper clause that builds dispatch_span
and execute_span) to only consider a dispatch/execute pair when they share a
stable identifier (e.g., the span's trace id or a "command" attribute extracted
from span(span, :attributes)), by extracting that identifier from each received
span and tracking it alongside seen entries, then only return {dispatch_span,
execute_span} when both spans have the same identifier; continue accumulating
unrelated spans in seen until a matching pair is found or deadline expires.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b95eabeb-d495-4551-b26f-ca4a68ab1b48
📒 Files selected for processing (2)
test/opentelemetry/dispatcher_retry_test.exstest/projections/support/setup.ex
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
