Skip to content

test(event): quiet expected handler retry logs #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 2 commits into from
Apr 29, 2026
Merged

test(event): quiet expected handler retry logs #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10089f2
test(event): quiet expected handler retry logs
yordis Apr 29, 2026
24b4d4f
test(event): restore logger module level safely
yordis Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions test/event/event_handler_error_handling_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,33 @@ defmodule Commanded.Event.EventHandlerErrorHandlingTest do
end

describe "Configured error handling" do
setup [:listen_for_telemetry_events, :start_simple_error_handler]
setup [:listen_for_telemetry_events]

test ":stop stops the handler", %{handler: handler, ref: ref} do
test ":stop stops the handler" do
%{handler: handler, ref: ref} = start_simple_error_handler!()
AppConfig.__put__(DefaultApp, :on_event_handler_error, :stop)

send_error_event(handler)

assert_receive {:DOWN, ^ref, :process, ^handler, :failed}
end

test ":backoff delays the next attempt", %{handler: handler} do
test ":backoff delays the next attempt" do
%{handler: handler} = start_simple_error_handler!()
AppConfig.__put__(DefaultApp, :on_event_handler_error, :backoff)
previous_level = Logger.get_module_level(Commanded.Event.Handler)

Logger.put_module_level(Commanded.Event.Handler, :emergency)

on_exit(fn ->
case previous_level do
[] ->
Logger.delete_module_level(Commanded.Event.Handler)

[{Commanded.Event.Handler, level}] ->
Logger.put_module_level(Commanded.Event.Handler, level)
end
end)
Comment thread
yordis marked this conversation as resolved.

# When we sent the error event
send_error_event(handler)
Expand All @@ -60,7 +75,8 @@ defmodule Commanded.Event.EventHandlerErrorHandlingTest do
2100
end

test "error handler can be a custom module", %{handler: handler, ref: ref} do
test "error handler can be a custom module" do
%{handler: handler, ref: ref} = start_simple_error_handler!()
AppConfig.__put__(DefaultApp, :on_event_handler_error, ThreeStrikesErrorHandler)

send_error_event(handler)
Expand Down Expand Up @@ -263,15 +279,15 @@ defmodule Commanded.Event.EventHandlerErrorHandlingTest do
end)
end

defp start_simple_error_handler(_) do
defp start_simple_error_handler! do
start_supervised!(DefaultApp)
handler = start_supervised!(SimpleErrorEventHandler)
true = Process.unlink(handler)
ref = Process.monitor(handler)

[
%{
handler: handler,
ref: ref
]
}
end
end