Skip to content

fix(grpc): preserve forwarded authentication failures - #510

Merged
yordis merged 17 commits into
masterfrom
yordis/fix-grpc-forwarded-auth-errors
Sep 24, 2026
Merged

yordis merged 17 commits into
masterfrom
yordis/fix-grpc-forwarded-auth-errors

Conversation

@yordis

@yordis yordis commented Sep 23, 2026 •

Copy link
Copy Markdown
Member
  • Forwarded writes must report authentication failures consistently with direct gRPC requests.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor

cursor Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches authentication error propagation for gRPC stream writes; behavior change for forwarded auth failures but no change to authorization decisions themselves.

Overview
Forwarded stream Append and Delete now map ClientMessage.NotAuthenticated replies to gRPC Unauthenticated errors (with the server reason), instead of failing as an unknown completion message.

Adds ForwardedAuthenticationTests to assert both RPCs surface StatusCode.Unauthenticated and include "forwarding denied" when the bus replies with NotAuthenticated.

Reviewed by Cursor Bugbot for commit 55bef09. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 4d040679-5a6e-4c0a-846d-e7c2d559e56d

📥 Commits

Reviewing files that changed from the base of the PR and between d30db04 and 55bef09.

📒 Files selected for processing (3)
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ForwardedAuthenticationTests.cs
  • src/EventStore.Core/Services/Transport/Grpc/Streams.Append.cs
  • src/EventStore.Core/Services/Transport/Grpc/Streams.Delete.cs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yordis yordis changed the title yordis/fix grpc forwarded auth errors fix(grpc): preserve forwarded authentication failures Sep 23, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis marked this pull request as ready for review September 23, 2026 16:29
@yordis
yordis requested a review from a team as a code owner September 23, 2026 16:29
Base automatically changed from yordis/fix-grpc-subscription-cleanup to master September 24, 2026 01:15
@yordis
yordis merged commit 0d1b2be into master Sep 24, 2026
9 checks passed
@yordis
yordis deleted the yordis/fix-grpc-forwarded-auth-errors branch September 24, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant