chore(tests): retire obsolete TCP integration fixtures

[yordis]

• Removes integration fixtures that only exercised the retired transport.

[cursor]

PR Summary

Low Risk
Changes are limited to test code and an internal HTTPS callback refactor with no intended production behavior change beyond what existing gRPC tombstone semantics already require.

Overview
Retires legacy TCP transport test suites (dispatcher, connection manager, SSL/plain connection, invalid-data integration, and TCP intermediate-certificate coverage) and drops the standalone copying_metadata fixture.

Refactors cluster node HTTPS setup for reuse in tests: Program.CreateServerOptionsSelectionCallback is split into a public-to-tests internal overload that accepts certificate/validator delegates, with InternalsVisibleTo for EventStore.Core.Tests. A new HTTP/Kestrel test asserts intermediate certificates are sent during TLS handshake using that helper.

Expands gRPC coverage: admin StartScavenge success and duplicate-start InProgress cases; stream-delete/tombstone scenarios now assert StreamRevision stays long.MaxValue on forward/backward read-all, subscribe, and subscribe-to-all (including a backward read-all path in the hard-delete fixture).

^{Reviewed by Cursor Bugbot for commit 09d3e31. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

Warning

Review limit reached

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ccbb9fe7-7477-42de-936b-24150da38856

📥 Commits

Reviewing files that changed from the base of the PR and between a57210d and 09d3e31.

📒 Files selected for processing (14)

• src/EventStore.ClusterNode/AssemblyInfo.cs
• src/EventStore.ClusterNode/Program.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/OperationsTests/AdminTests.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/read_all_events_forward_with_hard_deleted_stream_should.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/subscribe_should.cs
• src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/subscribe_to_all_should.cs
• src/EventStore.Core.Tests/Services/Transport/Http/with_intermediate_certificates.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpClientDispatcherTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionManagerTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionSslTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/TcpConnectionTests.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs
• src/EventStore.Core.Tests/Services/Transport/Tcp/with_intermediate_certificates.cs
• src/EventStore.Core.Tests/copying_metadata.cs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a4f79e7a-b417-4bcd-b045-76548adbe279

📥 Commits

Reviewing files that changed from the base of the PR and between 9989238 and a57210d.

📒 Files selected for processing (12)

• .config/mise/tasks/github/actions/dotnet-build
• .github/workflows/build-container-ubuntu-lts.yml
• scripts/test.sh
• src/EventStore.Core.Tests/Services/Storage/Scavenge/when_running_a_scavenge_from_storage_scavenger.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscription.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscriptionFiltered.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.CombinationTests.cs
• src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.StreamSubscription.CombinationTests.cs
• src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_tls.cs
• src/EventStore.Core.XUnit.Tests/Services/Archive/ArchiveCatchup/ArchiveCatchupTests.cs
• src/EventStore.Projections.Core.Tests/ClientAPI/specification_with_standard_projections_runnning.cs
• src/EventStore.TestClient/CommandsProcessor.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The pull request removes obsolete cluster, TCP, certificate, and metadata tests. It migrates scavenge and enumerator tests to gRPC. It adds an enumerator test shard and updates selected timeouts and TLS configuration tests.

Changes

Test and transport modernization

Layer / File(s)	Summary
Obsolete test fixture removal src/EventStore.Core.Tests/Integration/..., src/EventStore.Core.Tests/Services/Transport/Tcp/*, src/EventStore.Core.Tests/copying_metadata.cs	Removes cluster leader-transition, TCP transport, certificate-handshake, and metadata-copying fixtures.
gRPC test migration src/EventStore.Core.Tests/Services/Storage/Scavenge/..., src/EventStore.Core.Tests/Services/Transport/Enumerators/*	Replaces legacy client operations with gRPC channels, stream operations, RecordedEvent values, and explicit subscription cleanup.
Test execution and timeout updates .config/mise/tasks/github/actions/dotnet-build, .github/workflows/build-container-ubuntu-lts.yml, scripts/test.sh, src/EventStore.Core.XUnit.Tests/Services/Archive/..., src/EventStore.Projections.Core.Tests/..., src/EventStore.TestClient/CommandsProcessor.cs	Adds the core-enumerators shard and changes selected test, build, projection, cleanup, and command wait timeouts.
TLS configuration test updates src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_tls.cs	Renames SSL-focused fixtures, uses current certificate helpers, and removes secure TCP endpoint assertions.

Priority: ⬇️ Low

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Other

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 61 functions across 10 files. (2 skipped: …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the primary change: removal of obsolete TCP integration test fixtures.
Description check	✅ Passed	The description accurately covers the removal of integration fixtures for the retired transport.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 61 functions across 10 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the gRPC stream,
While old TCP tests leave the dream.
New shards hop through build-time queues,
TLS tests wear refreshed hues.
Timeouts stretch, and fixtures rest.}

_{Comment @coderabbitai help to get the list of available commands.}