Skip to content

Enhancing ActionData - #221

Merged
TuThoThai merged 18 commits into
v2.3-wipfrom
sx_cr_actiondata_enhancement
Oct 2, 2026
Merged

Enhancing ActionData#221
TuThoThai merged 18 commits into
v2.3-wipfrom
sx_cr_actiondata_enhancement

Conversation

@TuThoThai

@TuThoThai TuThoThai commented May 18, 2026

Copy link
Copy Markdown
Collaborator
  • Change in Prompt to embed MIME content type
  • Addition of Url with a specific type to embed MIME content type and language
  • All served with an example

This PR is to be discussed and merged before PR #210 that adds PublishToAudioAction. To include Url in ActionData addresses @skinkie comment

@TuThoThai
Enhancing ActionData
407f5f8 
- Change in `Prompt` to embed MIME content type
- Addition of `Url` with a specific type to embed MIME content type and language
- All served with an example
@TuThoThai TuThoThai added SX For everything SIRI-SX Needs CEN documentation Update These require CEN documentation update to match XSD & examples labels May 18, 2026
@TuThoThai TuThoThai added this to the v2.3 milestone May 18, 2026
@TuThoThai TuThoThai mentioned this pull request May 18, 2026
Merged
@skinkie

skinkie commented May 18, 2026

Copy link
Copy Markdown
Contributor

I would prefer that the Prompt itself is not changed in function. Hence if an organisation wants to do something with predefined markup that is fine, they can use Url text/html or application/xhtml+xml or maybe even something like image/svg+xml but lets keep the sane default just plain text.

@TuThoThai

TuThoThai commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

Since Url points to a different resource, regardeless of its type, I thought it would be nice to allow people to have a bit more choices in the format for text content in Prompt while taking advantage of adding the content-type attribute.

@TuThoThai TuThoThai mentioned this pull request May 18, 2026
Open
thbar
thbar reviewed May 19, 2026
View reviewed changes

@thbar thbar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a first round mostly on "details". I will mull over the general design & see if I can comment more on the overall structure (need more time).

Comment thread xsd/siri_model/siri_situationActions.xsd Outdated
Comment thread examples/siri_exm_SX/exm_situationExchange_responsewithpromptandurl.xml Outdated
Comment thread examples/siri_exm_SX/exm_situationExchange_responsewithpromptandurl.xml Outdated
Comment thread xsd/siri_utility/siri_types.xsd Outdated
@TuThoThai

TuThoThai commented May 19, 2026

Copy link
Copy Markdown
Collaborator Author

During the SIRI-SX meeting of 19 may 2026, the assessment was that the PR is not yet ready for review. Discussed changes / paints points are to be addressed.
Moving back this PR to draft to work on it and make it ready for review on 12 June 2026

@TuThoThai
TuThoThai marked this pull request as draft May 19, 2026 13:34
TuThoThai and others added 2 commits July 15, 2026 19:34
@TuThoThai
Re-work extension of ActionData
1eeadf6 
- Adding the element Url in ActionDataStructure
- Adding the attribute contentType for both Prompt and Url elements
- Defining the enumeration related to contentType
@TuThoThai
Merge branch 'v2.3-wip' into sx_cr_actiondata_enhancement
aeea607
@TuThoThai
TuThoThai marked this pull request as ready for review July 15, 2026 17:34
@TuThoThai

TuThoThai commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Based on feedback from the meeting of 19 May 2026, I made the following changes in the PR:

  • keeping the addition of the element Url in ActionDataStructure
  • adding the attribute contentType in both Prompt and Url
  • making the attribute contentType into an enumeration with a very limited list of allowed MIME types

@TuThoThai
Delete examples/siri_exm_SX/exm_situationExchange_responsewithprompta…
3ce1abd 
…ndurl.xml

delete faulty example from previous try
@TuThoThai
TuThoThai requested a review from thbar July 16, 2026 06:56
skinkie
skinkie reviewed Jul 16, 2026
View reviewed changes
Comment thread xsd/siri_model/siri_situationActions.xsd Outdated
TuThoThai
TuThoThai commented Jul 16, 2026
View reviewed changes

@TuThoThai TuThoThai left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion with @haeckerbaer, @skinkie and @thbar on 16 July 2026

Comment thread xsd/siri_utility/siri_types.xsd Outdated
@ue71603

ue71603 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

What is blocking this one?

haeckerbaer
haeckerbaer previously approved these changes Sep 16, 2026
View reviewed changes
Comment thread xsd/siri_utility/siri_types.xsd Outdated
haeckerbaer
haeckerbaer previously approved these changes Sep 29, 2026
View reviewed changes
thbar
thbar reviewed Sep 29, 2026
View reviewed changes
Comment thread xsd/siri_model/siri_situationActions.xsd Outdated
thbar
thbar reviewed Sep 29, 2026
View reviewed changes
Comment thread xsd/siri_utility/siri_types.xsd Outdated
thbar
thbar reviewed Sep 29, 2026
View reviewed changes
Comment thread xsd/siri_utility/siri_types.xsd
thbar
thbar reviewed Sep 29, 2026
View reviewed changes
Comment thread xsd/siri_utility/siri_types.xsd Outdated
@TuThoThai
edits after peer review
e26938d 
- List of additions in the XSD at the top of the Schema in the section for comments
- Change of the name of the type of value for URI content type
- Correction of typos in the XSD documentation
- Addition of content types in the enumeration for video + cleanup of values not used for broadcast
@TuThoThai
TuThoThai dismissed stale reviews from skinkie and haeckerbaer via e26938d October 1, 2026 15:08
@TuThoThai

TuThoThai commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

All the comments received during the SIRI plenary meeting and the peer-review have been addressed. This PR is ready for your final review @Aurige, @haeckerbaer, @skinkie, @thbar, @ue71603 and @Ulf9

@TuThoThai
TuThoThai requested review from skinkie and thbar October 1, 2026 15:59
@TuThoThai TuThoThai mentioned this pull request Oct 2, 2026
Closed
11 of 12 tasks
@skinkie

skinkie commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

My preference is that @Ulf9 lets us know if he is satisfied.

@skinkie
skinkie requested a review from Ulf9 October 2, 2026 09:10
thbar
thbar reviewed Oct 2, 2026
View reviewed changes
Comment thread xsd/siri_model/siri_situationActions.xsd
thbar
thbar reviewed Oct 2, 2026
View reviewed changes
Comment thread xsd/siri_model/siri_situationActions.xsd
thbar
thbar reviewed Oct 2, 2026
View reviewed changes
Comment thread xsd/siri_utility/siri_types.xsd
@TuThoThai
TuThoThai requested a review from thbar October 2, 2026 14:57
@TuThoThai
TuThoThai merged commit b90c5b0 into v2.3-wip Oct 2, 2026
1 check passed
@TuThoThai
TuThoThai deleted the sx_cr_actiondata_enhancement branch October 2, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thbar thbar thbar approved these changes
@haeckerbaer haeckerbaer haeckerbaer approved these changes
@ue71603 ue71603 Awaiting requested review from ue71603
@skinkie skinkie Awaiting requested review from skinkie
@Ulf9 Ulf9 Awaiting requested review from Ulf9

Assignees

No one assigned

Labels

Needs CEN documentation Update These require CEN documentation update to match XSD & examples SX For everything SIRI-SX

Projects

None yet

Milestone

v2.3

Development

Successfully merging this pull request may close these issues.

5 participants

@TuThoThai @skinkie @ue71603 @thbar @haeckerbaer