Skip to content

ci(codeql): exclude fetched dependencies from analysis - #42

Merged
dkrutskikh merged 3 commits into
mainfrom
upload-coverage-to-codecov
Aug 10, 2026
Merged

ci(codeql): exclude fetched dependencies from analysis#42
dkrutskikh merged 3 commits into
mainfrom
upload-coverage-to-codecov

Conversation

@dkrutskikh

@dkrutskikh dkrutskikh commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Build & Quality

    • Added automated upload of Linux unit-test coverage reports for improved coverage tracking.
    • Improved CodeQL build setup by keeping fetched dependencies in a temporary build location.
  • Performance

    • Updated MSVC Release and RelWithDebInfo builds to use stronger compiler optimization settings.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The changes add Linux unit-test coverage uploads, relocate CodeQL-fetched dependencies to the runner temporary directory, and update documented and active MSVC optimization flags from /O2 to /Ox.

Changes

Build and configuration updates

Layer / File(s) Summary
CI workflow updates
.github/workflows/build_cmake.yaml, .github/workflows/check_code_quality.yaml
The Linux build uploads unit_tests_coverage.info to Codecov with the units flag. The manual CodeQL build stores fetched dependencies under the runner’s temporary directory.
MSVC optimization flags
cmake/ConfigureCompiler.cmake
RelWithDebInfo and Release C/C++ flags use /Ox instead of /O2. The optimization comment also identifies /Ox.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: Review effort 1/5

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the CodeQL dependency-exclusion change, but it does not highlight the pull request's primary Codecov upload objective.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upload-coverage-to-codecov

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a34c41a). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #42   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        17           
  Branches        ?         0           
========================================
  Hits            ?        17           
  Misses          ?         0           
  Partials        ?         0           
Flag Coverage Δ
units 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dkrutskikh

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@dkrutskikh

Copy link
Copy Markdown
Member Author

@coderabbitai suggest PR title based on conventional commits policy

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

git diff --name-status HEAD^ HEAD
git diff --stat HEAD^ HEAD
git diff --no-ext-diff --unified=40 HEAD^ HEAD

Length of output: 3819


@dkrutskikh, use this PR title:

ci(codeql): exclude fetched dependencies from analysis

The current diff does not add a Codecov upload. It changes the CodeQL build configuration.

You are interacting with an AI system.

@dkrutskikh dkrutskikh changed the title feat: upload to codecov ci(codeql): exclude fetched dependencies from analysis Aug 10, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build_cmake.yaml:
- Line 311: Update the Codecov action reference in the workflow from the mutable
v7.0.0 tag to commit SHA fb8b3582c8e4def4969c97caa2f19720cb33a72f, retaining the
v7.0.0 version comment.

In `@cmake/ConfigureCompiler.cmake`:
- Around line 45-49: Update the MSVC release and RelWithDebInfo flag assignments
for CMAKE_C_FLAGS_RELWITHDEBINFO, CMAKE_CXX_FLAGS_RELWITHDEBINFO,
CMAKE_C_FLAGS_RELEASE, and CMAKE_CXX_FLAGS_RELEASE to use /O2 instead of /Ox,
and remove the misleading comment stating that the last option is /Ox.
- Line 31: Update the optimization flag comment in ConfigureCompiler so it
accurately describes /Ox as the base optimization set, /Ob3 as the explicit
inlining override, and /Ot as overriding the favor-fast-code setting provided by
/Ox.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 80f3ec20-b248-4683-8282-8afddbd76548

📥 Commits

Reviewing files that changed from the base of the PR and between a34c41a and a1abfb0.

📒 Files selected for processing (3)
  • .github/workflows/build_cmake.yaml
  • .github/workflows/check_code_quality.yaml
  • cmake/ConfigureCompiler.cmake

Comment thread .github/workflows/build_cmake.yaml
Comment thread cmake/ConfigureCompiler.cmake
Comment thread cmake/ConfigureCompiler.cmake
@dkrutskikh

Copy link
Copy Markdown
Member Author

@coderabbitai resolve

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Reviews resumed.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
✅ Action performed

Comments resolved and changes approved.

@dkrutskikh
dkrutskikh merged commit 109e2fd into main Aug 10, 2026
29 checks passed
@dkrutskikh
dkrutskikh deleted the upload-coverage-to-codecov branch August 10, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant