ci(codeql): exclude fetched dependencies from analysis - #42
Conversation
WalkthroughThe changes add Linux unit-test coverage uploads, relocate CodeQL-fetched dependencies to the runner temporary directory, and update documented and active MSVC optimization flags from ChangesBuild and configuration updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 17
Branches ? 0
========================================
Hits ? 17
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@coderabbitai suggest PR title based on conventional commits policy |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
git diff --name-status HEAD^ HEAD
git diff --stat HEAD^ HEAD
git diff --no-ext-diff --unified=40 HEAD^ HEADLength of output: 3819
The current diff does not add a Codecov upload. It changes the CodeQL build configuration. You are interacting with an AI system. |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/build_cmake.yaml:
- Line 311: Update the Codecov action reference in the workflow from the mutable
v7.0.0 tag to commit SHA fb8b3582c8e4def4969c97caa2f19720cb33a72f, retaining the
v7.0.0 version comment.
In `@cmake/ConfigureCompiler.cmake`:
- Around line 45-49: Update the MSVC release and RelWithDebInfo flag assignments
for CMAKE_C_FLAGS_RELWITHDEBINFO, CMAKE_CXX_FLAGS_RELWITHDEBINFO,
CMAKE_C_FLAGS_RELEASE, and CMAKE_CXX_FLAGS_RELEASE to use /O2 instead of /Ox,
and remove the misleading comment stating that the last option is /Ox.
- Line 31: Update the optimization flag comment in ConfigureCompiler so it
accurately describes /Ox as the base optimization set, /Ob3 as the explicit
inlining override, and /Ot as overriding the favor-fast-code setting provided by
/Ox.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 80f3ec20-b248-4683-8282-8afddbd76548
📒 Files selected for processing (3)
.github/workflows/build_cmake.yaml.github/workflows/check_code_quality.yamlcmake/ConfigureCompiler.cmake
|
@coderabbitai resolve |
✅ Action performedReviews resumed. |
✅ Action performedComments resolved and changes approved. |
Summary by CodeRabbit
Build & Quality
Performance