Repository navigation
feat(tui): implement debugger controls widget and keyboard navigation - #493
Merged
Merged
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
|
@Marywase Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeZe-us
self-requested a review
October 23, 2026 20:44
codeZe-us
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the debugger controls footer and connect it to interactive replay navigation. The footer shows available hotkeys, the selected replay position, CPU instructions, and memory usage with budget percentages when limits are available.
How It Was Done
Issues Encountered (If Any)
grat-core, including missingTypeRef, decoder argument mismatches, and metadata access errors. These were reproduced on unchanged upstreammainat4d7390ebe6721023ecf3b55da08382101c55361busing the same dependency lockfile. No core changes are included here.n/a. Navigation steps through recorded invocations; it does not implement live VM instruction stepping.Related Issue
Closes #484
How It Was Tested
rustfmt --edition 2021on the three changed Rust files; formatted files adopted.git diff --check: passed.cargo test -p grat tui:: -- --nocaptureand CLI Clippy: blocked by the core compilation errors above.cargo test --manifest-path /tmp/issue-484-harness/Cargo.toml -- --nocapture: 7 passed.cargo clippy --manifest-path /tmp/issue-484-harness/Cargo.toml --all-targets -- -D warnings: passed.The isolated harness compiles the actual TUI source files and actual core trace types, with only the network config/replay boundary stubbed. It validates UI rendering and state transitions, not network replay, terminal lifecycle on a physical terminal, or complete CLI integration. The harness and workflow remain on a separate fork validation branch, outside this PR.
Validation run, logs, harness, and artifacts.
Screenshots / Video (If Applicable)
Excerpt from the real TestBackend rendering of the fixture (not a live transaction):
The validation log contains the complete 120-column terminal buffer; tests also cover 60-, 40-, 1-, and 0-column layouts.
Conflict resolution (October 23)
Merged upstream
mainat2c58c74into this branch. The application now renders the upstream hierarchical timeline while preserving this PR's inspector, controls footer, step/navigation keys and resize handling. The upstream ledger header and all unrelated upstream stepper/search changes are preserved. Added a regression for synchronized timeline/inspector selection.Updated isolated validation: 18 TUI tests passed, including the upstream timeline widget tests; isolated Clippy with
-D warningspassed. Applied the workflow's Rustfmt output and checked the final diff. The harness uses actual TUI sources and trace types, with the network replay boundary stubbed. Fullcargo check -p gratremains blocked by 21 errors in unchanged upstream grat-core; the validation step tolerates that failure, so overall workflow success does not imply full CLI compilation passed. Existing malformed upstream CI and preview approval still require maintainer action.