Pin CI versions - #68
Conversation
There was a problem hiding this comment.
Pull request overview
This PR tightens CI workflow reproducibility by pinning some GitHub Actions to commit SHAs, and makes a few workflow cleanups (notably moving backend env vars to job-level and explicitly setting up Node for docs builds).
Changes:
- Pin
actions/checkoutanddorny/paths-filterto specific commit SHAs in multiple workflows. - Update Docs workflow to set up Node directly (with caching) instead of using the composite
setup-build-env. - Move backend CI environment variables from
$GITHUB_ENVwrites to job-levelenv.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/frontend.yml | Pins checkout/paths-filter; frontend build still uses setup-node by tag. |
| .github/workflows/docs.yml | Pins checkout/paths-filter; replaces composite setup with pinned setup-node + npm cache. |
| .github/workflows/deploy-dev.yml | Pins checkout; deploy still uses setup-dotnet by tag. |
| .github/workflows/backend.yml | Pins checkout/paths-filter; moves CI env vars to job-level env. |
Comments suppressed due to low confidence (2)
.github/workflows/frontend.yml:32
- The paths-filter includes
.github/actions/build-frontend/**, but there is no.github/actions/build-frontenddirectory in the repo. This filter entry will never match and can be removed to keep the workflow triggers accurate.
filters: |
frontend:
- "Networth.Frontend/**"
- ".github/actions/build-frontend/**"
.github/workflows/deploy-dev.yml:66
actions/setup-dotnetis still referenced by major tag (@v4). To fully pin CI dependencies (and align with the rest of this PR), consider pinning this action to a specific commit SHA and keeping the version comment (e.g.,# v4.x.y).
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
| - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3 | ||
| id: filter | ||
| with: | ||
| filters: | |
There was a problem hiding this comment.
The dorny/paths-filter config (see filters: block below this step) includes entries for .github/actions/build-docs/** (which doesn’t exist in the repo) and .github/actions/setup-build-env/** (which the docs job no longer uses). Removing/adjusting those paths will avoid stale filters and unnecessary docs workflow runs.
| - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3 | ||
| id: filter | ||
| with: | ||
| filters: | |
There was a problem hiding this comment.
The dorny/paths-filter configuration (in the filters: block for this step) includes .github/actions/build-backend/**, but there is no .github/actions/build-backend directory in the repo. Consider removing/updating that path so backend CI triggers reflect the actual action directories.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.