Skip to content

Pin CI versions - #68

Open
TomSB1423 wants to merge 3 commits into
mainfrom
feature/ci
Open

Pin CI versions#68
TomSB1423 wants to merge 3 commits into
mainfrom
feature/ci

Conversation

@TomSB1423

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 11, 2026 23:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens CI workflow reproducibility by pinning some GitHub Actions to commit SHAs, and makes a few workflow cleanups (notably moving backend env vars to job-level and explicitly setting up Node for docs builds).

Changes:

  • Pin actions/checkout and dorny/paths-filter to specific commit SHAs in multiple workflows.
  • Update Docs workflow to set up Node directly (with caching) instead of using the composite setup-build-env.
  • Move backend CI environment variables from $GITHUB_ENV writes to job-level env.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/frontend.yml Pins checkout/paths-filter; frontend build still uses setup-node by tag.
.github/workflows/docs.yml Pins checkout/paths-filter; replaces composite setup with pinned setup-node + npm cache.
.github/workflows/deploy-dev.yml Pins checkout; deploy still uses setup-dotnet by tag.
.github/workflows/backend.yml Pins checkout/paths-filter; moves CI env vars to job-level env.
Comments suppressed due to low confidence (2)

.github/workflows/frontend.yml:32

  • The paths-filter includes .github/actions/build-frontend/**, but there is no .github/actions/build-frontend directory in the repo. This filter entry will never match and can be removed to keep the workflow triggers accurate.
          filters: |
            frontend:
              - "Networth.Frontend/**"
              - ".github/actions/build-frontend/**"

.github/workflows/deploy-dev.yml:66

  • actions/setup-dotnet is still referenced by major tag (@v4). To fully pin CI dependencies (and align with the rest of this PR), consider pinning this action to a specific commit SHA and keeping the version comment (e.g., # v4.x.y).
      - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

      - name: Setup .NET
        uses: actions/setup-dotnet@v4
        with:

Comment on lines +28 to 31
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
id: filter
with:
filters: |

Copilot AI Feb 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dorny/paths-filter config (see filters: block below this step) includes entries for .github/actions/build-docs/** (which doesn’t exist in the repo) and .github/actions/setup-build-env/** (which the docs job no longer uses). Removing/adjusting those paths will avoid stale filters and unnecessary docs workflow runs.

Copilot uses AI. Check for mistakes.
Comment on lines +27 to 30
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3
id: filter
with:
filters: |

Copilot AI Feb 11, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dorny/paths-filter configuration (in the filters: block for this step) includes .github/actions/build-backend/**, but there is no .github/actions/build-backend directory in the repo. Consider removing/updating that path so backend CI triggers reflect the actual action directories.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/frontend.yml Outdated
TomSB1423 and others added 2 commits February 12, 2026 06:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants