Skip to content

fix: handle_gc_mod_list() return values in docs - #3062

Merged
toktok-releaser merged 1 commit into
TokTok:masterfrom
Green-Sky:minor_ngc_modlist_validation
Jun 20, 2026
Merged

fix: handle_gc_mod_list() return values in docs#3062
toktok-releaser merged 1 commit into
TokTok:masterfrom
Green-Sky:minor_ngc_modlist_validation

Conversation

@Green-Sky

@Green-Sky Green-Sky commented Jun 20, 2026

Copy link
Copy Markdown
Member

This change is Reviewable

@Green-Sky Green-Sky added this to the v0.2.24 milestone Jun 20, 2026
@github-actions github-actions Bot added the bug Bug fix for the user, not a fix to a build script label Jun 20, 2026
@Green-Sky
Green-Sky marked this pull request as ready for review June 20, 2026 12:59

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JFreegman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on Green-Sky).


toxcore/group_chats.c line 3046 at r1 (raw file):

    if (unpack_ret == 1) {
        // validation failed
        return -2;

0 is likely the correct return code with incorrect/lacking documentation.

@Green-Sky
Green-Sky force-pushed the minor_ngc_modlist_validation branch from 285d722 to 53c8669 Compare June 20, 2026 13:27
@Green-Sky Green-Sky changed the title fix: return error code as documented fix: handle_gc_mod_list() return values in docs Jun 20, 2026
@Green-Sky
Green-Sky force-pushed the minor_ngc_modlist_validation branch from 53c8669 to 1d79022 Compare June 20, 2026 13:55

@JFreegman JFreegman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

@JFreegman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on Green-Sky).

@codecov

codecov Bot commented Jun 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.38%. Comparing base (093ff1a) to head (1d79022).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   69.84%   69.38%   -0.46%     
==========================================
  Files         185      185              
  Lines       34375    34422      +47     
==========================================
- Hits        24009    23884     -125     
- Misses      10366    10538     +172     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@toktok-releaser
toktok-releaser merged commit 1d79022 into TokTok:master Jun 20, 2026
109 of 110 checks passed
@Green-Sky
Green-Sky deleted the minor_ngc_modlist_validation branch June 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix for the user, not a fix to a build script

Development

Successfully merging this pull request may close these issues.

3 participants