fix: handle_gc_mod_list() return values in docs - #3062
Conversation
JFreegman
left a comment
There was a problem hiding this comment.
@JFreegman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on Green-Sky).
toxcore/group_chats.c line 3046 at r1 (raw file):
if (unpack_ret == 1) { // validation failed return -2;
0 is likely the correct return code with incorrect/lacking documentation.
285d722 to
53c8669
Compare
53c8669 to
1d79022
Compare
JFreegman
left a comment
There was a problem hiding this comment.
@JFreegman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on Green-Sky).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
- Coverage 69.84% 69.38% -0.46%
==========================================
Files 185 185
Lines 34375 34422 +47
==========================================
- Hits 24009 23884 -125
- Misses 10366 10538 +172 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This change is