fix(onion): Size GCA announce response buffer to actual content length. - #3050
Merged
Conversation
github-actions
Bot
added
the
bug
Add GCA_ANNOUNCE_RESPONSE_MAX_SIZE to capture the true upper bound of a GCA-extended announce response, and allocate the response buffer dynamically to match the exact plaintext size rather than using the non-GCA constant. Update onion_client.c to accept responses up to the new bound. Add a group announce response size test.
Green-Sky
force-pushed
the
gc-announce-fix
branch
from
May 22, 2026 08:36
0ea1635 to
2385300
Compare
JFreegman
approved these changes
May 23, 2026
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
@JFreegman reviewed 7 files and all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GCA_ANNOUNCE_RESPONSE_MAX_SIZE to capture the true upper bound of a GCA-extended announce response, and allocate the response buffer dynamically to match the exact plaintext size rather than using the non-GCA constant. Update onion_client.c to accept responses up to the new bound. Add a group announce response size test.
This change is