fix(gca): announce max sizes where 32bytes too large - #3048
Merged
Conversation
github-actions
Bot
added
the
bug
Green-Sky
force-pushed
the
gca_announce_sizing
branch
from
May 21, 2026 08:03
9cf376b to
06ff743
Compare
Green-Sky
marked this pull request as ready for review
May 21, 2026 08:04
Member
|
It's been a few years since I looked at this code. How is it 32 bytes too large? |
Green-Sky
commented
May 21, 2026
Green-Sky
force-pushed
the
gca_announce_sizing
branch
from
May 21, 2026 15:53
06ff743 to
38affe5
Compare
Green-Sky
changed the title
JFreegman
approved these changes
May 23, 2026
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
@JFreegman reviewed 5 files and all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3048 +/- ##
==========================================
+ Coverage 68.10% 69.42% +1.32%
==========================================
Files 184 184
Lines 34361 34361
==========================================
+ Hits 23401 23856 +455
+ Misses 10960 10505 -455 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Green-Sky
force-pushed
the
gca_announce_sizing
branch
from
May 23, 2026 12:47
38affe5 to
5080b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis complained on the sender side that it might overflow. In practice this could never happen.
This change is