fix(DHT): refactor memory handling of loaded dht state - #3047
Merged
Conversation
github-actions
Bot
added
the
bug
JFreegman
approved these changes
May 23, 2026
JFreegman
left a comment
JFreegman
left a comment
Member
There was a problem hiding this comment.
@JFreegman reviewed 2 files and all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained.
Previous code could double-free if more than one dht states per tox-file and a following allocation fails. Also changed/removed dead var references in comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code could double-free if more than one dht states per tox-file and a following allocation fails. (it did not set
dht->loaded_nodes_list = nullptraftermem_delete())Also changed/removed dead var references in comments.
This change is