additional_data: sources: add licence info

[BibianaC]

relates to #213

I have added the licence to the additional data sources.
The API will be done in a different PR.

[Bjwebb]

I'm not sure why we're doing _LICENCE here, compared to https://github.com/ThreeSixtyGiving/datastore/pull/258/changes#diff-d3929aef8ca975fa331395aa7d04c5dc0b85608c6aed7ab04f3a45cf32fa4095R15-R22 which is additional_data[self.ADDITIONAL_DATA_KEY]["source_license"].

[BibianaC]

Thanks @Bjwebb , I made some changes.

[mariongalley]

Not sure how to test so asked for Matt's review instead

[Bjwebb]

This is looking good, if the outputted JSON is what we want. Could you share an example grant JSON? I think that might help me and @mrshll1001 review this.

[BibianaC]

@Bjwebb @mrshll1001

I have added print statements in the test.

print("\n\n=== ACTUAL GRANT DATA ===")
print(json.dumps(grant.data, indent=2))
print("\n\n=== ACTUAL ADDITIONAL DATA ===")
print(json.dumps(additional_data, indent=2))
print("\n\n")

The output:

=== ACTUAL GRANT DATA ===
{
  "id": "360G-kahM5Ooc2u",
  "title": "The luumuch5Ir grant",
  "currency": "GBP",
  "awardDate": "2019-10-03T00:00:00+00:00",
  "description": "Example grant description",
  "dateModified": "2019-08-03T00:00:00Z",
  "fromOpenCall": "Yes",
  "plannedDates": [
    {
      "endDate": "2017-02-15",
      "duration": 4,
      "startDate": "2016-10-03"
    }
  ],
  "amountAwarded": 971,
  "grantProgramme": [
    {
      "code": "00200200220",
      "title": "Example grants August 2019"
    }
  ],
  "beneficiaryLocation": [
    {
      "name": "England; Scotland; Wales",
      "geoCode": "K02000001",
      "geoCodeType": "CTRY"
    }
  ],
  "fundingOrganization": [
    {
      "id": "GB-example-b",
      "name": "Funding for examples"
    }
  ],
  "recipientOrganization": [
    {
      "id": "360G-example-a",
      "name": "Receive an example grant",
      "postalCode": "SW1 1AA",
      "streetAddress": "10 Downing street",
      "addressCountry": "United Kingdom",
      "addressLocality": "LONDON"
    }
  ]
}

=== ACTUAL ADDITIONAL DATA ===
{
  "metadata": {
    "source_license_name": "Creative Commons Attribution 4.0",
    "source_license": "https://creativecommons.org/licenses/by/4.0/",
    "sources_metadata": {
      "recipientOrgInfos": {
        "license": "https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/"
      },
      "locationLookup": {
        "license": "https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/"
      },
      "recipientOrganizationLocation": {
        "license": "https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/"
      },
      "codeListLookup": {
        "license": "https://creativecommons.org/licenses/by/4.0/"
      }
    }
  }
}

[Bjwebb]

I think if you can confirm that output is correct, the code looks good.

[BibianaC]

Thanks @Bjwebb . @mrshll1001 is it okay for you?

[mrshll1001]

Yes this looks OK to me.