Repository navigation
graft batch 23: 2 lands from backlog-1 - #186
Merged
Merged
Conversation
The Dropdown/Combobox/TagPicker listbox draws on its own Foreground layer that was not in egui's area order, so a Dialog's modal layer blocked its clicks. Register it as a sublayer of the opening layer (or move it to top over the page) and set its area state for hit testing. Adds overlay_in_dialog tests. Graft-Changeset: c372bab851b322eca9bc34eb9f077801b3818544781bd4118109675d7fd5769b5 Graft-Session: ses_01M65Z15N2Z0CBQ1V8ZN5CHVYK Claimed-Author: thedancingdeveloper <306930456+thedancingdeveloper@users.noreply.github.com> Graft-Batch: 23
The popup-above-modal fix in c372bab works: the Dropdown and Combobox modal tests fail without register_popup_layer and pass with it. Add a Dropdown-outside-Dialog regression test and a Tooltip-in-modal test. Graft-Changeset: c00f0fdb83c3a32178dc3f6d7b16c59cf2217d22e191ddd792f95b93ff3b7734a Graft-Session: ses_01M6600A0XR9HHWCQ863DN16PD Claimed-Author: thedancingdeveloper <306930456+thedancingdeveloper@users.noreply.github.com> Graft-Batch: 23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 23 of graft line
backlog-1, one commit per land, oldest first, by graft-mirror (decision D26). Merge it with rebase-merge to keep the commits (D28). graft never merges or queues this PR.mainat e914e0b (graft c16d6868d7021001492e3d5f9b88334a7d06c05bf5d5c1e35353150c540dea807)c00f0fdb83c3ac372bab851b32Graft-Batch: 23
Graft-Line: backlog-1
Graft-Changeset: c00f0fdb83c3a32178dc3f6d7b16c59cf2217d22e191ddd792f95b93ff3b7734a