Skip to content

add role attributes#22

Open
tiye wants to merge 9 commits into
mainfrom
role
Open

add role attributes#22
tiye wants to merge 9 commits into
mainfrom
role

Conversation

@tiye

@tiye tiye commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@tiye tiye requested review from a team and Copilot June 10, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Calcit/Respo generated snapshot and related dependencies, primarily to add ARIA role/aria-label attributes to interactive UI elements.

Changes:

  • Bump @calcit/procs and several Calcit/Respo dependencies.
  • Update calcit.cirru snapshot with many string literal/schema normalization changes plus new role/aria-label attributes.
  • Adjust .gitattributes generated-file diff settings.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Updates lockfile for bumped dependencies.
package.json Bumps @calcit/procs dependency version.
deps.cirru Updates Calcit/Respo dependency versions used by the project.
calcit.cirru Regenerates snapshot; adds ARIA roles/labels and other formatting/schema changes.
.gitattributes Removes generated-file diff suppression for calcit.cirru.
Comments suppressed due to low confidence (11)

calcit.cirru:425

  • The :min-width value appears to have been mangled (extra | and a trailing escaped quote), which will likely produce an invalid CSS value at runtime.
    calcit.cirru:551
  • This clickable element is given role=button but does not appear to be keyboard-focusable or keyboard-activatable. Also, turn-string is referenced here but is not defined anywhere in the repo (only turn-str is used elsewhere), which will likely break at runtime/compile time.
    calcit.cirru:368
  • comp-abort renders a non-interactive element with role=button but without keyboard support. For accessibility, it should be focusable (tabIndex) and handle Enter/Space to trigger the same action as click.
    calcit.cirru:451
  • This div is being used as a button (role=button) but lacks keyboard support (focus + Enter/Space activation). Screen-reader users may also not be able to reach it without tabIndex.
    calcit.cirru:523
  • This anchor is used as a button (role=button) but is not focusable by default (no href) and has no keyboard activation handler. Add tabIndex and handle Enter/Space to make it accessible.
    calcit.cirru:591
  • This div is given role=button but has no keyboard support. Add tabIndex and handle Enter/Space so it can be activated without a mouse.
    calcit.cirru:612
  • This element is assigned role=button but only handles mouse clicks; it isn't focusable/activatable via keyboard. Add tabIndex and an Enter/Space key handler so users can expand the prompt without a mouse.
    calcit.cirru:668
  • This clear-control span uses role=button but lacks keyboard support. It should be focusable (tabIndex) and respond to Enter/Space so it can be activated without a mouse.
    calcit.cirru:739
  • This session row is a div with role=button but isn't keyboard accessible. Add tabIndex and an Enter/Space key handler to trigger the same selection behavior as :on-click.
    calcit.cirru:754
  • This delete control is a div with role=button but isn't keyboard accessible. Add tabIndex and handle Enter/Space so users can delete a session without a mouse.
    calcit.cirru:772
  • These anchors are used as buttons (role=button) but have no href, so they are not focusable by default and don't support keyboard activation. Add tabIndex and handle Enter/Space to ensure they are accessible.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .gitattributes
Comment on lines 1 to 2

calcit.cirru -diff linguist-generated
yarn.lock -diff linguist-generated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants