Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Calcit/Respo generated snapshot and related dependencies, primarily to add ARIA role/aria-label attributes to interactive UI elements.
Changes:
- Bump
@calcit/procsand several Calcit/Respo dependencies. - Update
calcit.cirrusnapshot with many string literal/schema normalization changes plus newrole/aria-labelattributes. - Adjust
.gitattributesgenerated-file diff settings.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates lockfile for bumped dependencies. |
package.json |
Bumps @calcit/procs dependency version. |
deps.cirru |
Updates Calcit/Respo dependency versions used by the project. |
calcit.cirru |
Regenerates snapshot; adds ARIA roles/labels and other formatting/schema changes. |
.gitattributes |
Removes generated-file diff suppression for calcit.cirru. |
Comments suppressed due to low confidence (11)
calcit.cirru:425
- The
:min-widthvalue appears to have been mangled (extra|and a trailing escaped quote), which will likely produce an invalid CSS value at runtime.
calcit.cirru:551 - This clickable element is given
role=buttonbut does not appear to be keyboard-focusable or keyboard-activatable. Also,turn-stringis referenced here but is not defined anywhere in the repo (onlyturn-stris used elsewhere), which will likely break at runtime/compile time.
calcit.cirru:368 comp-abortrenders a non-interactive element withrole=buttonbut without keyboard support. For accessibility, it should be focusable (tabIndex) and handle Enter/Space to trigger the same action as click.
calcit.cirru:451- This
divis being used as a button (role=button) but lacks keyboard support (focus + Enter/Space activation). Screen-reader users may also not be able to reach it withouttabIndex.
calcit.cirru:523 - This anchor is used as a button (
role=button) but is not focusable by default (nohref) and has no keyboard activation handler. AddtabIndexand handle Enter/Space to make it accessible.
calcit.cirru:591 - This
divis givenrole=buttonbut has no keyboard support. AddtabIndexand handle Enter/Space so it can be activated without a mouse.
calcit.cirru:612 - This element is assigned
role=buttonbut only handles mouse clicks; it isn't focusable/activatable via keyboard. AddtabIndexand an Enter/Space key handler so users can expand the prompt without a mouse.
calcit.cirru:668 - This clear-control
spanusesrole=buttonbut lacks keyboard support. It should be focusable (tabIndex) and respond to Enter/Space so it can be activated without a mouse.
calcit.cirru:739 - This session row is a
divwithrole=buttonbut isn't keyboard accessible. AddtabIndexand an Enter/Space key handler to trigger the same selection behavior as:on-click.
calcit.cirru:754 - This delete control is a
divwithrole=buttonbut isn't keyboard accessible. AddtabIndexand handle Enter/Space so users can delete a session without a mouse.
calcit.cirru:772 - These anchors are used as buttons (
role=button) but have nohref, so they are not focusable by default and don't support keyboard activation. AddtabIndexand handle Enter/Space to ensure they are accessible.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
2
|
|
||
| calcit.cirru -diff linguist-generated | ||
| yarn.lock -diff linguist-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.