Repository navigation
Conversation
The docs deploy pushes to gh-pages, a single shared ref, so two master merges landing seconds apart deploy in parallel and the slower job's `mike deploy -p` is rejected as non-fast-forward. That is what broke run 35215109985: Teoroo-CMC#47 and Teoroo-CMC#46 merged 36 seconds apart, Teoroo-CMC#47 won the race, and Teoroo-CMC#46's docs fix never reached the site while everything else in the run was green. Waiting for a PR's docs deploy to finish before merging the next one avoids the race, so this does not serialize deploys automatically. It only opens the repair path: the workflow already accepted workflow_dispatch, but deploy-docs was gated on `github.event_name == 'push'`, so a manual run rebuilt and tested without ever redeploying the docs. Accepting workflow_dispatch there makes "Run workflow" on master actually replay the deploy.
Roy-Kid
force-pushed
the
ci/manual-docs-deploy
branch
from
September 17, 2026 12:12
4d04fc7 to
a3f0c21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Deploy docsjob pushes the built site togh-pageswithmike deploy -p.gh-pagesis a single shared ref, so two master merges landing close together deploy in parallel and the slower job's push is rejected:That is what broke run 35215109985 — #47 and #46 merged 36 seconds apart, #47's deploy won the race, and #46's docs fix never reached the site. Everything else in the run (pytest on Py3.9/3.10/3.11 + TF 2.15, both docker builds) was green.
Change
Waiting for a PR's docs deploy to finish before merging the next one avoids the race, so this does not serialize deploys automatically. It only opens the repair path for when the race happens anyway.
The workflow already listed
workflow_dispatchunderon:, butdeploy-docswas gated ongithub.event_name == 'push'— so "Run workflow" rebuilt and re-tested without ever redeploying the docs. The gate now acceptsworkflow_dispatchas well, with theTeoroo-CMC/PiNNand master/v*-ref conditions unchanged. One line plus a comment explaining the race; no new file and no duplicated deploy steps.Note that a manual run still goes through
needs: pytestfirst, so a replay costs a full test matrix (~10 min). That seemed better than duplicating the checkout/install/mike deployblock into a second workflow just to skip the tests.Test plan
on:keepspush/pull_request/workflow_dispatch, anddeploy-docskeeps its steps andneeds: pytestgh-pagesis currently back in sync (re-ran the failed job — the site is atb166b86), so the condition can be tested from a clean stategh-pagesadvancesworkflow_dispatchrun from a non-master branch still skipsdeploy-docs