Repository navigation
test(video): stabilize playback checks and retain CI evidence - #500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video browser CI can sample a previous frame after an MP4 seek, reporting red instead of blue in the encoder regression or white instead of red in the CLI/DSH regression. Main runs 40204484660 and 40306791830 show the affected assertions, and the original encoder failure was reproduced locally.
Every capture pixel check, including the route scan and dense late-overlay scan, now waits for both seek completion and presentation of the expected frame. Resolve the frame's presentation timestamp from the MP4 packet table and compare it with rVFC
mediaTime; comparing directly to the requested seek time would reject valid long-lived static frames. Reuse verified repeated frames, move same-position seeks within the target frame, and reject unavailable metadata or out-of-range requests explicitly. Existing color, overlay, duration, recovery and export assertions remain active.Retain MP4s, browser version, recording metadata, sampled pixels, screenshots and the Vitest JSON report. Evidence collection failures warn without replacing the test result, including optional CDP export failures. Metadata is saved before playback and updated after successful sampling so a playback failure still leaves useful evidence. Allow 30 minutes for the job's Chrome download, cold Rust build, video tests and native-dialog regressions.
Validation:
results.jsonand route MP4/JSON evidence were downloaded and verified from the updated Linux run. The reporter syntax is exercised by the actual workflow.