fix(cliparr): check release tag existence through git refs - #192
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release creation failed for a new tag because GitHub's commits endpoint returns HTTP 422 when the tag does not exist, while the script only allowed HTTP 404. Check the exact tag through the Git refs endpoint, which returns 404 for an absent tag, and resolve the fully qualified tag ref to a commit only when it exists.
Preserves retry updates and conflicting-target rejection, including annotated tags. Adds regression coverage for absent tags, existing tags without releases, missing tags on existing releases, and API errors that must stop publication.
Validation: all 38 release tests and
pnpm preflightpassed. Read-only checks against GitHub confirmed the missing-tag 404 and successful resolution of an existing release tag.After merging, start a new Release workflow run from
main; retrying the failed run retains its original commit.Failed job: https://github.com/TechSquidTV/Cliparr/actions/runs/34557937141/job/103134510079