[Fix] Issue-1094 Redirect /api/logo to signed CloudFront URL - #1098
[Fix] Issue-1094 Redirect /api/logo to signed CloudFront URL#1098foreverabhi2002 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Code reviewThe change itself is small and correct for the stated goal, but it is a breaking public-API change and a few things around it are unhandled. 1. Documentation still describes the old JSON contract
Please update these in this PR, and consider whether existing consumers need an opt-out (e.g. 2. Redirect is cacheable but the target expires in 5 minutes
3. The redirect target isn't always your CDN
4. Cross-origin consumersBrowser JS calling 5. Mixed response shapesSuccess is now a redirect while every error path still returns the TestsAsserting
Nothing blocking in the implementation itself — items 1–3 are what I'd want fixed before merge. |



Description
Closes #1094
Updated the
/api/logoendpoint to redirect successful logo requests directly to the generated signed CloudFront url instead of returning the url inside a JSON response.This allows the API endpoint to be used directly as an image source in HTML, Markdown, email templates, and other clients that expect an image resource.
The existing authentication, validation, rate limiting, logo lookup, and error handling behavior remains unchanged.
What type of PR is this? (Check all applicable)
Screenshots (if applicable)
Checklist