Repository navigation
feat(protocol): add song explorer JSON contracts - #4
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformSongSummary.CoverFallbackUrl(coverFallbackUrlin web JSON) for a pinned GitHub fallback to the primary CDN cover. Missing or null values remain compatible, and the existing positional constructor is unchanged.Validation
dotnet test tests/Sirius.Protocol.Tests -c Release: 11/11 passed, 0 skipped. The same 11 tests also passed against the actual local NuGet packages without a sibling-source project reference.Sirius.Protocol.Testsis not included inSiriusData.sln. These are explicit local test results, not a claim that the current solution-level CI step runs the contract tests.Rollout / dependent PRs
maincommit's build and rolling-release jobs to succeed, then verify that thelatestrelease records that commit and both NuGet packages have the same generated version.This PR does not publish a release or tag. The public
latestassets have not been asserted to contain these new contracts, and local integration validation does not establish that the consumers' default restore/build already succeeds against the public release.Consumer PRs: SiriusServer #18 and SiriusDashboard #9.
CI / publication status (2026-10-04)
mainbuild, rolling release and paired assets. The local validation evidence above remains separate from publication and normal consumer CI.Related PRs
Coordinated merge and release order
mainfirst.mainrevision's build and rolling-release jobs to succeed. Verify that publiclatestidentifies the release commit containing Data feat(protocol): add song explorer JSON contracts #4 and that the pairedSirius.Protocol.nupkgandSirius.MasterData.nupkgassets are available with the same generated version and matching published checksums. A successful Data PR build withrolling-releaseskipped is not a package publication.This coordination does not authorize automatic merging or publish a release. The new Song Explorer contracts were not yet in the public rolling packages at this verification:
lateststill identified2dc4f08b07c5c57ff99d4f2be6f060d14a44e2d4, with assets last updated on 2026-10-03; the Data PR commitc699660fbe55d7175906aba848c2865098dceaadis one commit ahead of that tag.