Skip to content

[WIP]: DONOT MERGE Fix invalid quest definition URLs - #127

Open
susrisha wants to merge 1 commit into
developfrom
bugfix-3644-workspace-settings-quest-link
Open

[WIP]: DONOT MERGE Fix invalid quest definition URLs#127
susrisha wants to merge 1 commit into
developfrom
bugfix-3644-workspace-settings-quest-link

Conversation

@susrisha

@susrisha susrisha commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • validate external Long Form Quest URLs as JSON matching the configured quest schema before saving
  • keep Workspace Settings usable when an existing invalid quest configuration fails to load
  • add regression coverage for both cases

Validation

  • npx eslint util/schema.ts components/settings/panel/Apps.vue test/e2e/settings.spec.ts
  • npm run typecheck
  • npm run test:e2e -- test/e2e/settings.spec.ts --workers=1

Fixes #3644

Refs #3644

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0e221318-bd63-4464-b448-10646f3d2f55


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@susrisha susrisha changed the title Fix invalid quest definition URLs [WIP]: DONOT MERGE Fix invalid quest definition URLs Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant