Repository navigation
WQ-0383b: /legacy/<page>.html reaches FastAPI (^~ /legacy in both nginx configs) - #30
Merged
Merged
Conversation
… block Live defect at deployed 5cc53eb: GET /legacy/assets.html -> 404 while /legacy/assets works. nginx picks the longest-matching PREFIX location (/legacy, proxy) and the regex (\.html$ no-cache block) wins over a plain prefix; the regex block has no root/try_files, so the request falls back to the server root's nonexistent legacy/assets.html path and 404s. Fix: 'location ^~ /legacy' in BOTH nginx configs (^~ stops the regex search, the pattern /next/static already uses). test_next_default_routing pin updated to require ^~ with the reason inline. Non-.html legacy paths, old V1 URLs, and every other route are unchanged.
Overview
Labels (5 changes)
org.opencontainers.image.authors=Chris Catalano
org.opencontainers.image.base.name=python:3.11-slim
-org.opencontainers.image.created=2026-10-21T16:36:49.684Z
-org.opencontainers.image.description=A Better Crypto Tracker
+org.opencontainers.image.description=Multi-chain cryptocurrency portfolio tracker supporting Cardano, Ethereum, Bitcoin, Solana, Polygon, and Base
org.opencontainers.image.documentation=https://github.com/Tarrant64/abct/blob/main/README.md
org.opencontainers.image.icon=https://raw.githubusercontent.com/Tarrant64/abct/main/frontend/static/apple-touch-icon.png
org.opencontainers.image.licenses=MIT
-org.opencontainers.image.revision=6bf63da647a097cc89e2d531b6535cb7d4496bdc
org.opencontainers.image.source=https://github.com/Tarrant64/abct
-org.opencontainers.image.title=abct
+org.opencontainers.image.title=ABCT - A Better Crypto Tracker
org.opencontainers.image.url=https://github.com/Tarrant64/abct
org.opencontainers.image.vendor=ABCT Project
-org.opencontainers.image.version=latest
+org.opencontainers.image.version=1.12.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged #29 (5cc53eb): live defect fix on the new /legacy route.
GET /legacy/assets.html -> 404 in production (nginx regex
\.html$no-cache block beats the plain prefix location /legacy and has no root), while /legacy/assets works.Fix:
location ^~ /legacyin both nginx configs (same pattern as /next/static), pin updated in test_next_default_routing.py with the reason inline. Full suite green at this head (venv:abct).Opened by
hub-prfor the Hermes leadagenton hub01 (branchhermes/WQ-0383b, head677fc548615b, 1 commit(s) onmain). Not reviewed by a person; merging is the owner's decision.