Skip to content

[TASK] Collect all composer fix commands in runTest.sh fix command - #1989

Merged
oliverklee merged 1 commit into
mainfrom
1855-one-fix-command
Aug 3, 2026
Merged

[TASK] Collect all composer fix commands in runTest.sh fix command#1989
oliverklee merged 1 commit into
mainfrom
1855-one-fix-command

Conversation

@kanow

@kanow kanow commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Resolves: #1855

@coveralls

coveralls commented Mar 3, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 25311978449

Coverage remained the same at 96.678%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 301
Covered Lines: 291
Line Coverage: 96.68%
Coverage Strength: 3.98 hits per line

💛 - Coveralls

@kanow
kanow force-pushed the 1855-one-fix-command branch 2 times, most recently from dc6350c to b6bfc54 Compare March 3, 2026 09:03
@oliverklee

Copy link
Copy Markdown
Contributor

I'm hesitant to decide only between the two of us whether we'd like to have only one big fixing task instead of also the individual tasks. So, I'd prefer to come to a team decision on this. I'll put this on the next team meeting agenda and mark this as draft until then.

@kanow

kanow commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author
  1. Mmmh.. too much confusion for me ;-) with related Add fix command to runTests.sh #1855 Old issue with pending decision. Can we speed up that decision making?

@kanow kanow removed their assignment Aug 3, 2026
@kanow kanow moved this from In Progress to Todo in Best Practices code sprint Aug 3, 2026
@kanow

kanow commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

After talk with @oliverklee 👍

  • asking @AnReiter which commands are still not refactored to bash scripts
    • fix command should do both, check things (with dry-run option) and fix things (is default, without dry-run option)
  • the replace composer command in docs without composer (don't forget index)

@kanow
kanow force-pushed the 1855-one-fix-command branch from f2fff73 to 53ed1c6 Compare August 3, 2026 13:43
@kanow
kanow marked this pull request as ready for review August 3, 2026 13:48
@kanow kanow moved this from Todo to In Review in Best Practices code sprint Aug 3, 2026
Comment thread Build/Scripts/runTests.sh Outdated
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Aug 3, 2026
@kanow
kanow force-pushed the 1855-one-fix-command branch from 53ed1c6 to 7d5387c Compare August 3, 2026 14:13
@kanow kanow moved this from In Progress to In Review in Best Practices code sprint Aug 3, 2026
Comment thread Build/Scripts/runTests.sh Outdated
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in Best Practices code sprint Aug 3, 2026
@kanow
kanow force-pushed the 1855-one-fix-command branch from 7d5387c to 4f36b13 Compare August 3, 2026 14:40
@kanow kanow moved this from In Progress to In Review in Best Practices code sprint Aug 3, 2026
@kanow
kanow requested a review from oliverklee August 3, 2026 14:40
@oliverklee
oliverklee merged commit 18c5b0b into main Aug 3, 2026
33 checks passed
@oliverklee
oliverklee deleted the 1855-one-fix-command branch August 3, 2026 14:57
@github-project-automation github-project-automation Bot moved this from In Review to Done in Best Practices code sprint Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Add fix command to runTests.sh

4 participants