Speedup pubilc courses rpc - #1929
Open
coolgirl19 wants to merge 2 commits into
Open
Conversation
| } | ||
|
|
||
| if user == nil { | ||
| dao.Cache.SetWithTTL(fmt.Sprintf("publicCoursesSummary-%d-%s", year, term), resp, 1, 6*time.Hour) |
Member
There was a problem hiding this comment.
here I'd prefer a minute just to shield us from spikes during hot hours when large streams start.
| Where("course_id = streams.course_id AND recording = ?", true) | ||
|
|
||
| return func(db *gorm.DB) *gorm.DB { | ||
| return db.Where("(recording = ? AND start = (?)) OR start > NOW()", true, latestRecording). |
Member
There was a problem hiding this comment.
This will yield all upcoming streams, no?
Member
There was a problem hiding this comment.
Maybe something like this works?
// Subquery 1: Latest past recording per course
latestRecording := DB.Model(&model.Stream{}).
Select("MAX(start)").
Where("course_id = streams.course_id AND recording = ? AND start <= NOW()", true)
// Subquery 2: Next upcoming stream per course
nextUpcoming := DB.Model(&model.Stream{}).
Select("MIN(start)").
Where("course_id = streams.course_id AND start > NOW()")
// Combined Filter
func publicCourseStreamFilter() func(*gorm.DB) *gorm.DB {
return func(db *gorm.DB) *gorm.DB {
return db.Where("start = (?) OR start = (?)", latestRecording, nextUpcoming).
Order("start asc")
}
}
| @@ -0,0 +1 @@ | |||
| package dao | |||
Member
There was a problem hiding this comment.
What's that file? Either add tests or delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.