Add MariaDB UPDATE RETURNING INTO support with feature detection - #935
Merged
abondvt89 merged 4 commits intoSep 22, 2026
Merged
Conversation
abondvt89
approved these changes
Sep 22, 2026
Contributor
|
Merging after reviews of the two current members of the TPC OSS Code Maintenance Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for MariaDB
UPDATE ... RETURNING ... INTOin the TPROC-CNEWORDstored procedure.The implementation uses feature detection rather than a MariaDB version check. During schema creation HammerDB attempts to create a temporary stored procedure containing
UPDATE ... RETURNING ... INTO.If supported,
NEWORDusesUPDATE ... RETURNING ... INTOfor the district and stock updates, removing the separateSELECT ... FOR UPDATE/UPDATEoperations.If unsupported, HammerDB retains the existing implementation.
Validation
UPDATE ... RETURNINGis supported.UPDATE ... RETURNING ... INTOis not supported.NEWORDimplementation.bb-13.1-bar-MDEV-39563:UPDATE ... RETURNING ... INTOis supported and executes successfully.NEWORDimplementation.This allows the optimisation to be used when MDEV-39563 support is available while retaining compatibility with existing MariaDB releases.
Fixes #933.